style(php-cs-fixer): lint php files and fix coding standards

github-actions · github-actions[bot] · commit 4446383bdce5 · 2024-05-26T11:40:36.000Z
diff --git a/src/Bridge/Laravel/Console/Commands/Database/ListCommand.php b/src/Bridge/Laravel/Console/Commands/Database/ListCommand.php
@@ -48,7 +48,7 @@ public function handle(DatabaseConfig $config, DatabaseProviderInterface $dbal):
         $databaseArgumentValue = $this->argument('db');
 
         /** @var array<string> $databases */
-        $databases = (null !== $databaseArgumentValue)
+        $databases = ($databaseArgumentValue !== null)
             ? [$databaseArgumentValue]
             : array_keys($config->getDatabases());
 
diff --git a/src/Bridge/Laravel/Console/Commands/Database/TableCommand.php b/src/Bridge/Laravel/Console/Commands/Database/TableCommand.php
@@ -226,7 +226,7 @@ private function describeType(AbstractColumn $column): string
             $type .= " ({$column->getSize()})";
         }
 
-        if ('decimal' === $abstractType) {
+        if ($abstractType === 'decimal') {
             $type .= " ({$column->getPrecision()}, {$column->getScale()})";
         }
 
diff --git a/src/Bridge/Laravel/Console/Commands/Migrations/MigrateCommand.php b/src/Bridge/Laravel/Console/Commands/Migrations/MigrateCommand.php
@@ -32,7 +32,7 @@ public function handle(): int
         $found = false;
         $count = $this->option('one') ? 1 : PHP_INT_MAX;
 
-        while (0 < $count && null !== ($migration = $this->migrator->run())) {
+        while ($count > 0 && null !== ($migration = $this->migrator->run())) {
             $found = true;
             --$count;
 
diff --git a/src/Bridge/Laravel/Console/Commands/Migrations/RollbackCommand.php b/src/Bridge/Laravel/Console/Commands/Migrations/RollbackCommand.php
@@ -33,7 +33,7 @@ public function handle(): int
         $found = false;
         $count = ! $this->option('all') ? 1 : PHP_INT_MAX;
         try {
-            while (0 < $count && null !== ($migration = $this->migrator->rollback())) {
+            while ($count > 0 && null !== ($migration = $this->migrator->rollback())) {
                 $found = true;
                 --$count;
                 $this->line(
diff --git a/src/Bridge/Laravel/Console/Commands/Migrations/StatusCommand.php b/src/Bridge/Laravel/Console/Commands/Migrations/StatusCommand.php
@@ -16,6 +16,7 @@
 final class StatusCommand extends AbstractCommand
 {
     private const DATE_TIME_FORMAT = 'Y-m-d H:i:s';
+
     private const PENDING = '<fg=red>not executed yet</fg=red>';
 
     protected $signature = 'cycle:migrate:status';
diff --git a/src/Bridge/Laravel/Providers/CycleServiceProvider.php b/src/Bridge/Laravel/Providers/CycleServiceProvider.php
@@ -38,7 +38,7 @@ public function boot(): void
         $config = $this->app->get(IlluminateConfig::class);
         $warmup = $config->get('cycle.warmup');
 
-        if (true === $warmup) {
+        if ($warmup === true) {
             /** @var CycleORM $orm */
             $orm = $this->app->get(ORMInterface::class);
             $orm->prepareServices();
diff --git a/src/Bridge/Laravel/Providers/Registrator.php b/src/Bridge/Laravel/Providers/Registrator.php
@@ -7,11 +7,18 @@
 interface Registrator
 {
     public const CFG_KEY = 'cycle';
+
     public const CFG_KEY_DATABASE = 'cycle.database';
+
     public const CFG_KEY_TOKENIZER = 'cycle.tokenizer';
+
     public const CFG_KEY_ATTRIBUTES = 'cycle.attributes';
+
     public const CFG_KEY_MIGRATIONS = 'cycle.migrations';
+
     public const CFG_KEY_SCHEMA = 'cycle.schema';
+
     public const CFG_KEY_WARMUP = 'cycle.warmup';
+
     public const CFG_KEY_RELATIONS = 'cycle.customRelations';
 }
diff --git a/src/Bridge/Laravel/Rules/Exists.php b/src/Bridge/Laravel/Rules/Exists.php
@@ -31,7 +31,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
 
         $count = $table->where([$this->column => $value])->count();
 
-        if (0 === $count) {
+        if ($count === 0) {
             $fail($this->message());
         }
     }
diff --git a/src/Bridge/Laravel/Rules/Unique.php b/src/Bridge/Laravel/Rules/Unique.php
@@ -31,7 +31,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void
 
         $count = $table->where([$this->column => $value])->count();
 
-        if (0 < $count) {
+        if ($count > 0) {
             $fail($this->message());
         }
     }
diff --git a/src/Bridge/Telescope/Events/Database/QueryExecuted.php b/src/Bridge/Telescope/Events/Database/QueryExecuted.php
@@ -13,6 +13,6 @@ final class QueryExecuted
     public function __construct(public string $sql, public array $bindings, public ?float $time, public ?string $driver = null)
     {
         $this->time = $time * 1000;
-        $this->driver = null !== $driver ? 'CycleORM/' . $driver : 'CycleORM';
+        $this->driver = $driver !== null ? 'CycleORM/' . $driver : 'CycleORM';
     }
 }
diff --git a/src/Bridge/Telescope/TelescopeLogger.php b/src/Bridge/Telescope/TelescopeLogger.php
@@ -21,7 +21,7 @@ public function log($level, $message, array $context = []): void
     {
         $this->parentLogger->log($level, $message, $context);
 
-        if ('info' === $level && isset($context['elapsed'])) {
+        if ($level === 'info' && isset($context['elapsed'])) {
             event(
                 new QueryExecuted(
                     sql: $message,
diff --git a/src/Bridge/Telescope/Watchers/QueryWatcher.php b/src/Bridge/Telescope/Watchers/QueryWatcher.php
@@ -32,7 +32,7 @@ public function recordQuery(QueryExecuted $event): void
         $time = $event->time;
         $caller = $this->getCallerFromStackTrace();
 
-        if (null !== $caller) {
+        if ($caller !== null) {
             Telescope::recordQuery(IncomingEntry::make([
                 'connection' => $event->driver,
                 'bindings' => $event->bindings,
diff --git a/src/Contracts/GeneratorLoader.php b/src/Contracts/GeneratorLoader.php
@@ -9,7 +9,9 @@
 interface GeneratorLoader
 {
     public const GROUP_INDEX = 'index';
+
     public const GROUP_RENDER = 'render';
+
     public const GROUP_POSTPROCESS = 'postprocess';
 
     /**
diff --git a/src/Schema/Compiler.php b/src/Schema/Compiler.php
@@ -17,6 +17,11 @@ final class Compiler
 {
     private const EMPTY_SCHEMA = ':empty:';
 
+    public function __construct(
+        private readonly mixed $schema
+    ) {
+    }
+
     public static function compile(Registry $registry, GeneratorLoader $queue): self
     {
         return new self((new CycleSchemaCompiler())->compile($registry, $queue->get()));
@@ -27,14 +32,9 @@ public static function fromMemory(CacheManager $cache): self
         return new self($cache->get());
     }
 
-    public function __construct(
-        private readonly mixed $schema
-    ) {
-    }
-
     public function isEmpty(): bool
     {
-        return null === $this->schema || [] === $this->schema || self::EMPTY_SCHEMA === $this->schema;
+        return $this->schema === null || $this->schema === [] || $this->schema === self::EMPTY_SCHEMA;
     }
 
     public function toSchema(): SchemaInterface
diff --git a/src/Schema/Generators/GeneratorQueue.php b/src/Schema/Generators/GeneratorQueue.php
@@ -16,7 +16,9 @@
 
 final class GeneratorQueue implements GeneratorLoader
 {
-    /** @var array<array<GeneratorInterface|class-string<GeneratorInterface>>> */
+    /**
+     * @var array<array<GeneratorInterface|class-string<GeneratorInterface>>>
+     */
     private array $generators;
 
     private Container $app;
diff --git a/src/Testing/Constraints/HasInDatabase.php b/src/Testing/Constraints/HasInDatabase.php
@@ -37,7 +37,7 @@ public function matches(mixed $other): bool
         try {
             $count = $tableInterface->where($this->data)->count();
 
-            return 0 < $count;
+            return $count > 0;
         } catch (Throwable $e) {
             return false;
         }
diff --git a/src/Testing/Constraints/NotSoftDeletedInDatabase.php b/src/Testing/Constraints/NotSoftDeletedInDatabase.php
@@ -42,7 +42,7 @@ public function matches(mixed $other): bool
                 ->andWhere($this->deletedAtColumn, '=', null)
                 ->count();
 
-            return 0 < $count;
+            return $count > 0;
         } catch (Throwable $e) {
             return false;
         }
diff --git a/src/Testing/Constraints/SoftDeletedInDatabase.php b/src/Testing/Constraints/SoftDeletedInDatabase.php
@@ -42,7 +42,7 @@ public function matches(mixed $other): bool
                 ->andWhere($this->deletedAtColumn, '!=', null)
                 ->count();
 
-            return 0 < $count;
+            return $count > 0;
         } catch (Throwable $e) {
             return false;
         }
diff --git a/tests/app/Entities/Footprint.php b/tests/app/Entities/Footprint.php
@@ -21,6 +21,13 @@ final class Footprint implements JsonSerializable, Stringable
 
     private readonly string $realm;
 
+    private function __construct(UserId $id, string $party, string $realm)
+    {
+        $this->id = $id;
+        $this->party = $party;
+        $this->realm = $realm;
+    }
+
     public static function empty(string $authorizedParty = 'guest-party', string $realm = 'guest-realm'): self
     {
         return new self(UserId::create(Uuid::NIL), $authorizedParty, $realm);
@@ -86,11 +93,4 @@ public function __toString(): string
     {
         return json_encode($this->toArray(), JSON_THROW_ON_ERROR);
     }
-
-    private function __construct(UserId $id, string $party, string $realm)
-    {
-        $this->id = $id;
-        $this->party = $party;
-        $this->realm = $realm;
-    }
 }
diff --git a/tests/app/Entities/Signature.php b/tests/app/Entities/Signature.php
@@ -25,6 +25,12 @@ class Signature
     #[Column(type: 'json', nullable: true, typecast: [Footprint::class, 'castValue'])]
     private ?Footprint $by = null;
 
+    public function __construct(?DateTimeImmutable $at, ?Footprint $by)
+    {
+        $this->at = $at;
+        $this->by = $by;
+    }
+
     public static function forGuest(): self
     {
         return new self(new DateTimeImmutable(), Footprint::empty());
@@ -78,10 +84,4 @@ public function toArray(): array
             'by' => $this->by?->toArray(),
         ];
     }
-
-    public function __construct(?DateTimeImmutable $at, ?Footprint $by)
-    {
-        $this->at = $at;
-        $this->by = $by;
-    }
 }
diff --git a/tests/app/Entities/UserId.php b/tests/app/Entities/UserId.php
@@ -11,6 +11,11 @@ final class UserId implements Stringable
 {
     private readonly string $id;
 
+    private function __construct(string $id)
+    {
+        $this->id = $id;
+    }
+
     public static function create(string $userId): self
     {
         return new self($userId);
@@ -35,9 +40,4 @@ public function __toString(): string
     {
         return $this->toString();
     }
-
-    private function __construct(string $id)
-    {
-        $this->id = $id;
-    }
 }
diff --git a/tests/src/Bridge/Laravel/LoggerFactoryTest.php b/tests/src/Bridge/Laravel/LoggerFactoryTest.php
@@ -78,7 +78,7 @@ public function it_should_fire_query_executed_event_when_query_is_logged(): void
 
         // Assert that the QueryExecuted event was dispatched
         Event::assertDispatched(QueryExecuted::class, function ($event) {
-            return 'SELECT * FROM users' === $event->sql;
+            return $event->sql === 'SELECT * FROM users';
         });
     }
 

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ private function describeType(AbstractColumn $column): string`
`226`	`226`	`$type .= " ({$column->getSize()})";`
`227`	`227`	`}`
`228`	`228`
`229`		`- if ('decimal' === $abstractType) {`
	`229`	`+ if ($abstractType === 'decimal') {`
`230`	`230`	`$type .= " ({$column->getPrecision()}, {$column->getScale()})";`
`231`	`231`	`}`
`232`	`232`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`final class StatusCommand extends AbstractCommand`
`17`	`17`	`{`
`18`	`18`	`private const DATE_TIME_FORMAT = 'Y-m-d H:i:s';`
	`19`	`+`
`19`	`20`	`private const PENDING = '<fg=red>not executed yet</fg=red>';`
`20`	`21`
`21`	`22`	`protected $signature = 'cycle:migrate:status';`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function validate(string $attribute, mixed $value, Closure $fail): void`
`31`	`31`
`32`	`32`	`$count = $table->where([$this->column => $value])->count();`
`33`	`33`
`34`		`- if (0 === $count) {`
	`34`	`+ if ($count === 0) {`
`35`	`35`	`$fail($this->message());`
`36`	`36`	`}`
`37`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ final class QueryExecuted`
`13`	`13`	`public function __construct(public string $sql, public array $bindings, public ?float $time, public ?string $driver = null)`
`14`	`14`	`{`
`15`	`15`	`$this->time = $time * 1000;`
`16`		`- $this->driver = null !== $driver ? 'CycleORM/' . $driver : 'CycleORM';`
	`16`	`+ $this->driver = $driver !== null ? 'CycleORM/' . $driver : 'CycleORM';`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function log($level, $message, array $context = []): void`
`21`	`21`	`{`
`22`	`22`	`$this->parentLogger->log($level, $message, $context);`
`23`	`23`
`24`		`- if ('info' === $level && isset($context['elapsed'])) {`
	`24`	`+ if ($level === 'info' && isset($context['elapsed'])) {`
`25`	`25`	`event(`
`26`	`26`	`new QueryExecuted(`
`27`	`27`	`sql: $message,`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,9 @@`
`9`	`9`	`interface GeneratorLoader`
`10`	`10`	`{`
`11`	`11`	`public const GROUP_INDEX = 'index';`
	`12`	`+`
`12`	`13`	`public const GROUP_RENDER = 'render';`
	`14`	`+`
`13`	`15`	`public const GROUP_POSTPROCESS = 'postprocess';`
`14`	`16`
`15`	`17`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,11 @@ final class Compiler`
`17`	`17`	`{`
`18`	`18`	`private const EMPTY_SCHEMA = ':empty:';`
`19`	`19`
	`20`	`+ public function __construct(`
	`21`	`+ private readonly mixed $schema`
	`22`	`+ ) {`
	`23`	`+ }`
	`24`	`+`
`20`	`25`	`public static function compile(Registry $registry, GeneratorLoader $queue): self`
`21`	`26`	`{`
`22`	`27`	`return new self((new CycleSchemaCompiler())->compile($registry, $queue->get()));`
`@@ -27,14 +32,9 @@ public static function fromMemory(CacheManager $cache): self`
`27`	`32`	`return new self($cache->get());`
`28`	`33`	`}`
`29`	`34`
`30`		`- public function __construct(`
`31`		`- private readonly mixed $schema`
`32`		`- ) {`
`33`		`- }`
`34`		`-`
`35`	`35`	`public function isEmpty(): bool`
`36`	`36`	`{`
`37`		`- return null === $this->schema \|\| [] === $this->schema \|\| self::EMPTY_SCHEMA === $this->schema;`
	`37`	`+ return $this->schema === null \|\| $this->schema === [] \|\| $this->schema === self::EMPTY_SCHEMA;`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`public function toSchema(): SchemaInterface`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,9 @@`
`16`	`16`
`17`	`17`	`final class GeneratorQueue implements GeneratorLoader`
`18`	`18`	`{`
`19`		`- /** @var array<array<GeneratorInterface\|class-string<GeneratorInterface>>> */`
	`19`	`+ /**`
	`20`	`+ * @var array<array<GeneratorInterface\|class-string<GeneratorInterface>>>`
	`21`	`+ */`
`20`	`22`	`private array $generators;`
`21`	`23`
`22`	`24`	`private Container $app;`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function matches(mixed $other): bool`
`37`	`37`	`try {`
`38`	`38`	`$count = $tableInterface->where($this->data)->count();`
`39`	`39`
`40`		`- return 0 < $count;`
	`40`	`+ return $count > 0;`
`41`	`41`	`} catch (Throwable $e) {`
`42`	`42`	`return false;`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function matches(mixed $other): bool`
`42`	`42`	`->andWhere($this->deletedAtColumn, '=', null)`
`43`	`43`	`->count();`
`44`	`44`
`45`		`- return 0 < $count;`
	`45`	`+ return $count > 0;`
`46`	`46`	`} catch (Throwable $e) {`
`47`	`47`	`return false;`
`48`	`48`	`}`