Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density Inputs / Potential Outputs Should be Consistent and Flexible for RKS and UKS #79

Open
wavefunction91 opened this issue Oct 24, 2023 · 0 comments

Comments

@wavefunction91
Copy link
Owner

As of #78, UKS adopts a canonical Pauli definition of the density input / VXC output. RKS currently takes $D_\alpha$, which is not consistent with the Pauli definition. Looking forward to GKS, the Pauli implementation is superior as all input densities are Hermitian (as is not the case in the spin-separated convention), while one can go either way for RKS/UKS. We should also support the latter to allow for simple integration with spin-separated codes (which are the norm).

  1. RKS needs to (optionally) accept $D_s$ as input - this could be resolved by a strong type template parameter toggling the expected input. Luckily, the potential remains the same for either spin-separated or Pauli definitions of the density / potential.
  2. UKS needs to (optionally) accept $D_\alpha$ / $D_\beta$ as input and return $V_\alpha$ / $V_\beta$ as output. This does change the expected output by $\pm$ factors when this option would be enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant