Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve merging of str patterns #21

Open
waveform80 opened this issue Aug 21, 2021 · 0 comments
Open

Improve merging of str patterns #21

waveform80 opened this issue Aug 21, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@waveform80
Copy link
Owner

When the merge phase combines Str patterns, if either is undefined or unequal lengths are found, we just ditch the entire pattern. This could be more refined, e.g.zip_longest and mark the suffix regex-optional, although that begs the question what to do about combining optional suffixes, or if such a thing is even valid. Still, there's almost certainly room for some improvement here.

@waveform80 waveform80 added the enhancement New feature or request label Aug 21, 2021
@waveform80 waveform80 added this to the 1.0 milestone Aug 21, 2021
@waveform80 waveform80 self-assigned this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant