From 6d220faf8f3a0cdc0b369d18301a4e31bdf333f2 Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 13:44:15 -0700
Subject: [PATCH 01/12] fix: resolve accessibility issues

Fix the errors reported by Lighthouse.
---
 client/src/components/Header/Header.js            | 1 +
 client/src/index.html                             | 2 +-
 client/src/pages/NewTree/NewTreeButton.js         | 1 +
 client/src/pages/UserLocation/GeolocateControl.js | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/client/src/components/Header/Header.js b/client/src/components/Header/Header.js
index 70021ee6..0b52aa3e 100644
--- a/client/src/components/Header/Header.js
+++ b/client/src/components/Header/Header.js
@@ -41,6 +41,7 @@ const Header = () => {
           }}
           color="success"
           className="header__btn-menu"
+          title="Menu"
         >
           <MenuRoundedIcon
             sx={{ fontSize: '2.5rem', color: 'black' }}
diff --git a/client/src/index.html b/client/src/index.html
index 7762a3be..2ceceb44 100644
--- a/client/src/index.html
+++ b/client/src/index.html
@@ -5,7 +5,7 @@
 
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-    <meta name="viewport" content="initial-scale=1.0, user-scalable=no">
+    <meta name="viewport" content="initial-scale=1.0">
     <meta name="description" content="WATER THE TREES">
     <meta name="author" content="Code for San Francisco">
     <meta name="theme-color" content="#ffffff">
diff --git a/client/src/pages/NewTree/NewTreeButton.js b/client/src/pages/NewTree/NewTreeButton.js
index 0d9c7d38..0fec8d5b 100644
--- a/client/src/pages/NewTree/NewTreeButton.js
+++ b/client/src/pages/NewTree/NewTreeButton.js
@@ -84,6 +84,7 @@ export default function NewTreeButton({ map }) {
         value="Plant"
         selected={isPlanting}
         onChange={handlePlantClick}
+        title="Plant New Tree"
       />
       {map && <NewTreePlantingMarker map={map} onPlantClick={openPanel} />}
     </>
diff --git a/client/src/pages/UserLocation/GeolocateControl.js b/client/src/pages/UserLocation/GeolocateControl.js
index 96a22c52..ec082c06 100644
--- a/client/src/pages/UserLocation/GeolocateControl.js
+++ b/client/src/pages/UserLocation/GeolocateControl.js
@@ -60,7 +60,7 @@ export default function GeolocateControl({ map }) {
 
   return (
     <>
-      <IconButton onClick={handleClick} style={{ color: '#333' }}>
+      <IconButton title="Find Your Location" onClick={handleClick} style={{ color: '#333' }}>
         <GeolocateIcon
           isTracking={isTracking}
           isFollowingUser={isFollowingUser}

From fd741556dda9c5d96d9b1cbc15a11083549e46fb Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 16:23:32 -0700
Subject: [PATCH 02/12] test: Add Lighthouse CI locally

Added the Lighthouse CI config file.
I had to tweak the info message
server/index.js emits, because Lighthouse
needs to see something like "Listening on..."
to detect that the server has started.
---
 lighthouserc.js | 17 +++++++++++++++++
 server/index.js |  2 +-
 2 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 lighthouserc.js

diff --git a/lighthouserc.js b/lighthouserc.js
new file mode 100644
index 00000000..81b6fbbd
--- /dev/null
+++ b/lighthouserc.js
@@ -0,0 +1,17 @@
+module.exports = {
+  ci: {
+    collect: {
+      startServerCommand: 'npm run start:dev',
+      url: ['http://localhost:3001'],
+    },
+    assert: {
+      assertions: {
+        'categories:accessibility': ['error', { minScore: 1 }],
+        'categories:best-practices': ['error', { minScore: 1 }],
+      },
+    },
+    upload: {
+      target: 'temporary-public-storage',
+    },
+  },
+};
\ No newline at end of file
diff --git a/server/index.js b/server/index.js
index 77d7399a..77cbbe5a 100644
--- a/server/index.js
+++ b/server/index.js
@@ -38,4 +38,4 @@ app.get('/*', (req, res) => {
 });
 
 const httpServer = http.createServer(app);
-httpServer.listen(port, () => logger.info(`${host}:${port}`));
+httpServer.listen(port, () => logger.info(`listening on ${host}:${port}`));

From ac6624637ec3fa8f23df77689b1daf00fc2f757f Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 16:26:13 -0700
Subject: [PATCH 03/12] ci: Added Lighthouse CI github action

Lighthouse CI should now run in
pre-flight. The scores for accessibility
and best practices need to be 100 for CI
to pass.
---
 .github/workflows/lighthouse-ci.yaml | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 .github/workflows/lighthouse-ci.yaml

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
new file mode 100644
index 00000000..5d0d2964
--- /dev/null
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -0,0 +1,20 @@
+name: Build project and run Lighthouse CI
+on: [push]
+jobs:
+  lhci:
+    name: Lighthouse CI
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Use Node.js 18.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 18.x
+      - name: npm install production
+        run: |
+          npm install --production
+      - name: run Lighthouse CI
+        run: |
+          npm install -g @lhci/cli@10.1.0
+          npm run build
+          lhci autorun --upload.target=temporary-public-storage || echo "LHCI failed!"
\ No newline at end of file

From 4103eea2bc737eee5513f561d6b96f86d398f723 Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 16:46:24 -0700
Subject: [PATCH 04/12] test: Update snapshots

Adding a title for accessibility to Header
changed its test snapshot, so it had to be
updated.
---
 client/src/tests/__snapshots__/Header.test.js.snap | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/client/src/tests/__snapshots__/Header.test.js.snap b/client/src/tests/__snapshots__/Header.test.js.snap
index 9b51dd92..0f3fc540 100644
--- a/client/src/tests/__snapshots__/Header.test.js.snap
+++ b/client/src/tests/__snapshots__/Header.test.js.snap
@@ -390,6 +390,7 @@ exports[`<Header /> spec renders Header correctly 1`] = `
           <button
             class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorSuccess MuiIconButton-sizeSmall header__btn-menu emotion-0"
             tabindex="0"
+            title="Menu"
             type="button"
           >
             <svg
@@ -687,6 +688,7 @@ exports[`<Header /> spec renders Header correctly 1`] = `
         <button
           class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorSuccess MuiIconButton-sizeSmall header__btn-menu emotion-0"
           tabindex="0"
+          title="Menu"
           type="button"
         >
           <svg

From 61acd2af554032920af84ebd81540e9e66bd1509 Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 17:30:46 -0700
Subject: [PATCH 05/12] fix: pull the right @lhci/cli version

Pull the latest version of @lhci/cli
at major version 11.
---
 .github/workflows/lighthouse-ci.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index 5d0d2964..09e22b00 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -15,6 +15,6 @@ jobs:
           npm install --production
       - name: run Lighthouse CI
         run: |
-          npm install -g @lhci/cli@10.1.0
+          npm install -g @lhci/cli@0.11.x
           npm run build
-          lhci autorun --upload.target=temporary-public-storage || echo "LHCI failed!"
\ No newline at end of file
+          lhci autorun --upload.target=temporary-public-storage || echo "LHCI failed!"

From 7fbd25c0c7402b831449cb3cd2ce3ed044c13eba Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 17:47:39 -0700
Subject: [PATCH 06/12] fix: install all npm dependencies

Some of the dev dependencies are needed
for the webpack build, so let's just
install everything.
---
 .github/workflows/lighthouse-ci.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index 09e22b00..9a187960 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -10,9 +10,9 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: 18.x
-      - name: npm install production
+      - name: npm install
         run: |
-          npm install --production
+          npm install
       - name: run Lighthouse CI
         run: |
           npm install -g @lhci/cli@0.11.x

From d7d7218a95c0259ef43132c63f3a9c9ad144e30c Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Thu, 30 Mar 2023 18:55:44 -0700
Subject: [PATCH 07/12] fix: install chromium in github action

Lighthouse needs chromium, but trying
to test its installation in a Github
action is exceedingly difficult even
with nektos/act. Let's see if this works.
---
 .github/workflows/lighthouse-ci.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index 9a187960..f99c06b2 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -10,11 +10,12 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: 18.x
-      - name: npm install
+      - name: npm ci
         run: |
-          npm install
+          npm ci
       - name: run Lighthouse CI
         run: |
+          sudo apt install chromium
           npm install -g @lhci/cli@0.11.x
           npm run build
           lhci autorun --upload.target=temporary-public-storage || echo "LHCI failed!"

From 8402cd8540b54e4adb6f78f66ad903d26f46a602 Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Fri, 31 Mar 2023 13:10:03 -0700
Subject: [PATCH 08/12] test: Use a docker image for chrome

Pulls in browserless/chrome docker image
to have chrome pre-installed. I'm having
a lot of trouble with the PROTOCOL_TIMEOUT
error during lhci autorun, which is still
unresolved by Lighthouse (it's the #1
issue on the GoogleChrome/lighthouse
repo).
---
 .github/workflows/lighthouse-ci.yaml | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index f99c06b2..97f6d2ce 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -4,6 +4,15 @@ jobs:
   lhci:
     name: Lighthouse CI
     runs-on: ubuntu-latest
+    container:
+      image: browserless/chrome
+      options: --user root
+      env:
+        NODE_ENV: development
+      ports:
+        - 80
+      volumes:
+        - /docker_volume
     steps:
       - uses: actions/checkout@v1
       - name: Use Node.js 18.x
@@ -11,11 +20,13 @@ jobs:
         with:
           node-version: 18.x
       - name: npm ci
+        run: npm ci
+      - name: Run Lighthouse CI
         run: |
-          npm ci
-      - name: run Lighthouse CI
-        run: |
-          sudo apt install chromium
           npm install -g @lhci/cli@0.11.x
           npm run build
-          lhci autorun --upload.target=temporary-public-storage || echo "LHCI failed!"
+          lhci autorun \
+            --only-categories=accessibility,best-practices \
+            --collect.settings.chromeFlags="--no-sandbox --disable-gpu" \
+            --disable-dev-shm-usage \
+            --disable-storage-reset || echo "LHCI failed!"

From f2e8eeb4694bd51cc57f505fa05f3c7478c1b306 Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Fri, 31 Mar 2023 17:40:57 -0700
Subject: [PATCH 09/12] test: just download chrome manually

I do not want to deal with git auth
in docker images.
---
 .github/workflows/lighthouse-ci.yaml | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index 97f6d2ce..8ecfd50d 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -4,15 +4,6 @@ jobs:
   lhci:
     name: Lighthouse CI
     runs-on: ubuntu-latest
-    container:
-      image: browserless/chrome
-      options: --user root
-      env:
-        NODE_ENV: development
-      ports:
-        - 80
-      volumes:
-        - /docker_volume
     steps:
       - uses: actions/checkout@v1
       - name: Use Node.js 18.x
@@ -21,6 +12,11 @@ jobs:
           node-version: 18.x
       - name: npm ci
         run: npm ci
+      - name: Install chrome
+        run: |
+          wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+          sudo apt-get update
+          sudo apt-get install -y ./google-chrome-stable_current_amd64.deb
       - name: Run Lighthouse CI
         run: |
           npm install -g @lhci/cli@0.11.x

From 949a989804f22527cf618667db8da9ac28030b80 Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Sat, 1 Apr 2023 16:38:16 -0700
Subject: [PATCH 10/12] test: Add Lighthouse token

Added the Lighthouse token so we
can see status checks. The
lighthouse github action I pulled
in has some issue with CHROME_PATH,
so I'm going back to running
lhci autorun by itself.
---
 .github/workflows/lighthouse-ci.yaml | 15 +++++++--------
 lighthouserc.js                      |  5 +++++
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index 8ecfd50d..f58ee505 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -1,7 +1,7 @@
 name: Build project and run Lighthouse CI
 on: [push]
 jobs:
-  lhci:
+  lighthouse_ci:
     name: Lighthouse CI
     runs-on: ubuntu-latest
     steps:
@@ -11,7 +11,9 @@ jobs:
         with:
           node-version: 18.x
       - name: npm ci
-        run: npm ci
+        run: |
+          npm ci
+          npm run build
       - name: Install chrome
         run: |
           wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
@@ -20,9 +22,6 @@ jobs:
       - name: Run Lighthouse CI
         run: |
           npm install -g @lhci/cli@0.11.x
-          npm run build
-          lhci autorun \
-            --only-categories=accessibility,best-practices \
-            --collect.settings.chromeFlags="--no-sandbox --disable-gpu" \
-            --disable-dev-shm-usage \
-            --disable-storage-reset || echo "LHCI failed!"
+          lhci autorun
+        env:
+          LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
\ No newline at end of file
diff --git a/lighthouserc.js b/lighthouserc.js
index 81b6fbbd..61504c73 100644
--- a/lighthouserc.js
+++ b/lighthouserc.js
@@ -3,6 +3,11 @@ module.exports = {
     collect: {
       startServerCommand: 'npm run start:dev',
       url: ['http://localhost:3001'],
+      disableStorageReset: true,
+      disableDevShmUsage: true,
+      settings: {
+        'chromeFlags': '--no-sandbox --headless --disable-gpu',
+      },
     },
     assert: {
       assertions: {

From 244ea1587ebff815101bf4c16bf0db2a32652e7d Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Sat, 1 Apr 2023 17:11:26 -0700
Subject: [PATCH 11/12] fix: remove disable-storage-reset

reviewify recommended I remove it,
so I did. The machines tell us
what to do now.
---
 lighthouserc.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lighthouserc.js b/lighthouserc.js
index 61504c73..62f9df14 100644
--- a/lighthouserc.js
+++ b/lighthouserc.js
@@ -3,7 +3,6 @@ module.exports = {
     collect: {
       startServerCommand: 'npm run start:dev',
       url: ['http://localhost:3001'],
-      disableStorageReset: true,
       disableDevShmUsage: true,
       settings: {
         'chromeFlags': '--no-sandbox --headless --disable-gpu',

From 16b13c64252a527a9940b43e1565d14d9ae4c3ed Mon Sep 17 00:00:00 2001
From: Paul Grad <paulgrad3rd@gmail.com>
Date: Sat, 1 Apr 2023 17:56:37 -0700
Subject: [PATCH 12/12] test: Use latest github actions

---
 .github/workflows/lighthouse-ci.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/lighthouse-ci.yaml b/.github/workflows/lighthouse-ci.yaml
index f58ee505..c49ce2d5 100644
--- a/.github/workflows/lighthouse-ci.yaml
+++ b/.github/workflows/lighthouse-ci.yaml
@@ -5,9 +5,9 @@ jobs:
     name: Lighthouse CI
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v3
       - name: Use Node.js 18.x
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
           node-version: 18.x
       - name: npm ci