Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider how we treat and build the SDK #2150

Open
sodic opened this issue Jul 3, 2024 · 0 comments
Open

Reconsider how we treat and build the SDK #2150

sodic opened this issue Jul 3, 2024 · 0 comments
Labels
shouldfix We should do/fix this at some point

Comments

@sodic
Copy link
Contributor

sodic commented Jul 3, 2024

It seems we simultaneously treat the SDK as a package and as a project:

  • Package: we don't run npm install inside its folder, it's installed indirectly through the root package.json)
  • Project: We run tsc inside.

I can't remember exactly whether this is the case, but I'm 80% sure. We should double-check before further digging in. If that's the case, devDependencies may behave unexpectedly.

This is wrong and is probably the root cause of the problem described in #2085.

I'm guessing that older versions of NPM treat linked dependencies differently than the newer ones, and that it only works with the newer versions because we're relying on undefined behavior.

To understand what I mean, check the difference between a package-lock.json files generated with NPM versions 0.9.4 and 0.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shouldfix We should do/fix this at some point
Projects
None yet
Development

No branches or pull requests

1 participant