add warning logs for experimental & beta components #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jem-davies
changed the title
jem-davies
force-pushed
the
add-flags-allow-experimental-beta
branch
2 times, most recently
from
c8cee1d to
8f369ec
Compare
jem-davies
force-pushed
the
add-flags-allow-experimental-beta
branch
from
8f369ec to
57d659d
Compare
Collaborator
Author
|
Expecting the test github action to fail - but it would be fixed by: #508 |
Signed-off-by: Jem Davies <[email protected]>
jem-davies
force-pushed
the
add-flags-allow-experimental-beta
branch
from
57d659d to
3b92545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bento components have an associated 'Status', that can take the value of "stable", "beta", "experimental" & "deprecated". Currently the only way a user of Bento would understand they were using a "beta" / "experimental" component is if they have seen the warning on the component's doc page.
This PR will add an additional type of Lint Warning such that when a "beta" or "experimental" component is parsed, we will emit a Warning log, users will be able to silence these warnings with additional options
--allow-beta&--allow-experimental.In a future major update to Bento, we could alter this behaviour so that Bento will not execute a stream with "experimental" or "beta" components, unless explicitly allowed by the user.
This PR will add warning logs when a stream is created via:
bento -c config.yamlbento streams ./*.yamlIn a follow up PR I will alter the StreamBuilder API to allow modifying if we will log warnings for experimental / beta components.