Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this run faster #38

Open
shbrief opened this issue Apr 27, 2024 · 1 comment
Open

Make this run faster #38

shbrief opened this issue Apr 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@shbrief
Copy link
Contributor

shbrief commented Apr 27, 2024

Rewrite the apply-within-apply part?

lefser/R/lefser.R

Lines 24 to 32 in b059a62

group_formats <- apply(iters, 1L, function(x) {
ind <- unlist(whichlist[x])
apply(trelab_sub, 2L, function(g) {
wx <- suppressWarnings(coin::wilcox_test(g ~ group, subset = ind))
cbind.data.frame(
p.value = coin::pvalue(wx), statistic = coin::statistic(wx)
)
})
})

@lwaldron
Copy link
Member

As Jenny Bryan would say, it has a bad code "smell"

@LiNk-NY LiNk-NY self-assigned this Jun 20, 2024
@shbrief shbrief added the enhancement New feature or request label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants