Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: get rid of .js in imports #17

Open
weboko opened this issue Jan 25, 2023 · 1 comment
Open

chore: get rid of .js in imports #17

weboko opened this issue Jan 25, 2023 · 1 comment
Assignees
@weboko

Comments

@weboko
Copy link
Collaborator

weboko commented Jan 25, 2023

This is hard to keep track of presence of .js in imports.
Build system should handle it for us.

Example of issue: #16
@fryorcraken fryorcraken added this to Waku Jan 25, 2023
@weboko weboko moved this to In Progress in Waku Jan 25, 2023
@weboko weboko self-assigned this Jan 25, 2023
@fryorcraken
Copy link
Contributor

You need to update the tsconfig to

    "moduleResolution": "node16",

and tsc will detect when js extensions are missing.

@weboko weboko moved this from In Progress to To Do in Waku Mar 1, 2023
@weboko weboko mentioned this issue Sep 21, 2023
Closed
@weboko weboko moved this from To Do to Code Review / QA in Waku Sep 21, 2023
@weboko weboko moved this from Code Review / QA to To Do in Waku Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
None yet
Projects
Waku
Status: To Do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove .js in imports waku-org/js-waku
2 participants
@fryorcraken @weboko