Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a non checked logged-in rule, it will discard the rule #229

Open
TWOC-WHT opened this issue Dec 31, 2021 · 1 comment
Open

Comments

@TWOC-WHT
Copy link

I found a workaround solution, so hopefully this can help other people that are trying to make a logged-out segment (by not checking the logged-in rule.

Reproduce steps:

  1. Create a new segment
  2. Add "Add Logged In rule"
  3. Don't tick/check the rule (keep empty), as the aim is to create a logged-out segment
    image
  4. Save
  5. In the segment dashboard view, the segment won't have any rule.
    image
  6. If you go back to the configuration page of the segment, the logged-in rule is not saved, as if you didn't add it (thus making the segment having no rule)
    image

Current Fix/Workaround steps:

  1. Create a new segment
  2. Add "Add Logged In rule"
  3. Tick/check the rule (this is temporary)
    image
  4. Save
  5. In the segment dashboard view, the segment now shows the rule as "visitors are logged in"
    image
  6. Go back to the configuration, the logged-in rule is now properly saved
  7. Uncheck the rule (Not delete)
    image
  8. Save
  9. In the dashboard view, it now shows as having the rule as "visitors are not logged in"
    image

Suggestion:

For logged-in rule, maybe we can use a dropdown instead of a checkbox?

@easherma-truth
Copy link
Collaborator

You can use a dropdown, I think just if it isn't false by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants