fix ignoring the get_queryset() of ModelAdmin and get_base_queryset()… #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of InstanceSpecificView -this fixes #5727
Manage this branch in SquashTest this branch here: https://engamirengbug-fixmodeladmin-qu-v5slo.squash.io |
-like child classes of WMABaseView sets self.queryset
|
Hello, I'm closing since we no longer accepting PRs for new ModelAdmin features in Wagtail as per wagtail/rfcs#85. If you'd like, you could create a new PR to the wagtail-modeladmin repository. And for this PR in particular, per wagtail-nest/wagtail-modeladmin#21 (comment) this is an enhancement rather than a bug fix, so ideally this should be accompanied with documentation. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wagtail-nest/wagtail-modeladmin#21
none of the drived ViewClassed of InstanceSpecificView respected the get_queryset methods before
since InstanceSpecificView drives from WMABaseView I handled the issue as it is handled in WMABaseView