Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt seeder to an abstract class #185

Closed
jorgebodega opened this issue Oct 19, 2021 · 2 comments
Closed

Adapt seeder to an abstract class #185

jorgebodega opened this issue Oct 19, 2021 · 2 comments
Assignees
Labels
next This will be probably fixed on next Release

Comments

@jorgebodega
Copy link
Collaborator

To fix #119 we need to find a way to avoid the problem of export multiple elements but not checking if those are seeder.

A possible approach is to define Seeders as an abstract class instead of an interface. That will allow us to use instanceof to infer what could be used as a seeder. Similarly to new seeder of MikroORM.

Or we can discuss about allowing only default exports

@jorgebodega jorgebodega added the next This will be probably fixed on next Release label Oct 19, 2021
@jorgebodega jorgebodega self-assigned this Oct 19, 2021
@jorgebodega jorgebodega added this to To do in Next version via automation Oct 19, 2021
@jorgebodega jorgebodega moved this from To do to In progress in Next version Oct 19, 2021
@micalevisk
Copy link

+1 to class MySeeder extends Seeder { ... } approach.

@jorgebodega
Copy link
Collaborator Author

Closed by #191

Next version automation moved this from In progress to Done Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next This will be probably fixed on next Release
Projects
Development

No branches or pull requests

2 participants