Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant milestone 1 delivery #1217

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Grant milestone 1 delivery #1217

merged 1 commit into from
Nov 12, 2024

Conversation

lukastanisic99
Copy link
Contributor

@lukastanisic99 lukastanisic99 commented Oct 31, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2350

@lukastanisic99
Copy link
Contributor Author

The state of the project repository is also for milestone 2, but need to write an article for it. Expect an update in the next few days when the article is written. Do I have to coordinate with someone for the article?

@keeganquigley
Copy link
Contributor

Thanks @lukastanisic99 you can email [email protected] to coordinate the announcement.

@PieWol PieWol self-assigned this Nov 7, 2024
@PieWol
Copy link
Member

PieWol commented Nov 11, 2024

Hey @lukastanisic99 ,
thanks for the delivery. It looks like the testing guide is missing. I see two commands listed in the readme to test with yarn. Yet there should be a more expressive testing guide to walk the evaluator through the process of testing all features that are delivered with this milestone. Please provide me a link to the guide. I'd also expect the guide to cover the setup and testing with the dockerfile. :)

@lukastanisic99
Copy link
Contributor Author

@PieWol I've added a more detailed testing guide next to the docs - take a look https://github.com/peer3to/state-channels-plus/blob/master/docs/testingGuide.md

It covers tests both for milestone 1 and milestone 2

@PieWol PieWol changed the title Grant milestone delivery Grant milestone 1 delivery Nov 12, 2024
@PieWol
Copy link
Member

PieWol commented Nov 12, 2024

Thank you @lukastanisic99
You mentioned in the application that you are planning on having 7 FTEs working on this project. Yet I can only see commits made by you. The way you published all your existing code doesn't allow insights in previous commits. Who is now actually working on this project?

@lukastanisic99
Copy link
Contributor Author

@PieWol yes - we're targeting 7 but need to resolve funding first. In the grant PR it says 1 person 24/7 (me) and other part time. That's why all the commits are from me since I designed it and have full context of the implementation. Part time doesn't really work for core tech or it's not as efficient since people are constantly switching context and are working on different things and we want to finish this as soon as possible, so we can build the business side and make it sustainable. Others are mostly focused on the business, product and design parts that are more tolerable for part time contribution.

@PieWol
Copy link
Member

PieWol commented Nov 12, 2024

Okay, so it's not 7 but how many are now actually working on this grant project?

@lukastanisic99
Copy link
Contributor Author

Sorry if something was unclear. Currently, on this grant project (the code - public good - open source) only me since for now we got $0 for it and no VC is interested in funding public goods (if you know some send them our way). The rest are focused on the business. After you guys approve we'll ask the treasury to fund the completion of this project (public good).

@PieWol
Copy link
Member

PieWol commented Nov 12, 2024

thanks, understood.

@PieWol
Copy link
Member

PieWol commented Nov 12, 2024

With this evaluation your milestone delivery is accepted 🎉 .

@PieWol PieWol merged commit 62ecc82 into w3f:master Nov 12, 2024
6 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants