Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastic milestone 1 #1040

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Lastic milestone 1 #1040

merged 7 commits into from
Nov 13, 2023

Conversation

poppyseedDev
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2008 < please fill this in with the PR number of your application.

@semuelle
Copy link
Member

Thanks for the delivery, @poppyseedDev. Please give it a couple of days, we have quite the backlog currently. In the meantime, could you add the link to the whitepaper?

@poppyseedDev
Copy link
Contributor Author

Thanks for the delivery, @poppyseedDev. Please give it a couple of days, we have quite the backlog currently. In the meantime, could you add the link to the whitepaper?

No worries, thanks for letting us know. Btw I can't seem to pass the error, do you guys have an idea what might I be doing wrong?

Run w3f/parse-milestone-delivery-action@master
Error: Match not found for: milestone_number

@keeganquigley keeganquigley self-assigned this Nov 1, 2023
@keeganquigley
Copy link
Contributor

Thanks for the delivery @poppyseedDev it is unable to correctly parse the milestone number, can you try changing it to:

Milestone Number: 1

instead of:

Milestone Number: Milestone 1

Thanks!

@poppyseedDev
Copy link
Contributor Author

poppyseedDev commented Nov 6, 2023

Thanks for the delivery @poppyseedDev it is unable to correctly parse the milestone number, can you try changing it to:

Milestone Number: 1

instead of:

Milestone Number: Milestone 1

Thanks!

Great looks like all checks have passed now, thanks! Hopefully I am not bodering you guys too much, but could you possibly provide an estimated timeline for when the checks might be completed? It would help us a lot to plan accordingly. 🙂

@keeganquigley
Copy link
Contributor

Yep looks good, thanks @poppyseedDev and apologies for the delay, we have a bit of a backlog at the moment. I should be able to look at this tomorrow!

@keeganquigley
Copy link
Contributor

keeganquigley commented Nov 7, 2023

Hi @poppyseedDev I started my evaluation today and have the following initial comments:

  • The proposal states that "core functions will be fully covered by comprehensive UI testing framework" but the deliverable is blank. I know that it is all mock data but shouldn't there still be some tests here?
  • The docs still contain some boilerplate text like this markdown template, and this trader index. Is the website still a work-in-progress at this point?
  • Also, the Lastic repo linked in the bio appears to be private or moved.

@phillux
Copy link
Contributor

phillux commented Nov 8, 2023

Hi @keeganquigley

* The docs still contain some boilerplate text like this [markdown template](https://docs.lastic.xyz/markdown-examples.html), and this [trader index](https://docs.lastic.xyz/trader/). Is the website still a work-in-progress at this point?

The docs are now updated with fixed dead links and more information about how Coretime works.

* Also, the [Lastic repo](https://github.com/LasticXYZ/Lastic) linked in the bio appears to be private or moved.

All the code is now in the LasticUI repo, and the one you mentioned is deprecated. Let me know if there is any extra information or missing pieces you expected to be in there.

@keeganquigley
Copy link
Contributor

keeganquigley commented Nov 8, 2023

Thanks @phillux much appreciated. Moving on, the substrate-interact repo instructions say to use yarn for the front-end, but the static_frontend repo says to use pnpm. Is there a reason for using both package managers? yarn install works but it gives a warning about mixing package managers:

yarn install v1.22.19
warning ../../package.json: No license field
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error @azns/resolver-core@1.6.0: The engine "node" is incompatible with this module. Expected version ">=16 <=18". Got "20.6.1"
warning @azns/resolver-core@1.6.0: The engine "pnpm" appears to be invalid.
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

And then yarn start fails:

yarn run v1.22.19
warning ../../package.json: No license field
$ next start
[Error: ENOENT: no such file or directory, open '/Users/keeganquigley/LasticUI/static_frontend/.next/BUILD_ID'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/keeganquigley/LasticUI/static_frontend/.next/BUILD_ID'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

pnpm run dev also fails:

pnpm run dev

> lastic@0.1.0 dev /Users/keeganquigley/LasticUI/static_frontend
> next dev

FatalError: error TS6046: Argument for '--moduleResolution' option must be: 'node', 'classic', 'node16', 'nodenext'.

    at getTypeScriptConfiguration (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/lib/typescript/getTypeScriptConfiguration.js:49:19)
    at writeConfigurationDefaults (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/lib/typescript/writeConfigurationDefaults.js:178:117)
    at verifyTypeScriptSetup (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/lib/verify-typescript-setup.js:119:74)
    at async verifyTypeScript (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:108:26)
    at async startWatcher (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:129:29)
    at async setupDevBundler (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:1627:20)
    at async initialize (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-server.js:71:30)
    at async Server.<anonymous> (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/start-server.js:221:36)

Can you help me look into this? I'll try on Ubuntu as well. Should I be using the main branch?

@keeganquigley
Copy link
Contributor

UPDATE: Doing the same thing on Ubuntu:

ubuntu@ip-172-31-26-199:~/LasticUI/static_frontend$ yarn start
yarn run v1.22.19
$ next start
[Error: ENOENT: no such file or directory, open '/home/ubuntu/LasticUI/static_frontend/.next/BUILD_ID'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/ubuntu/LasticUI/static_frontend/.next/BUILD_ID'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@keeganquigley
Copy link
Contributor

Okay, I was able to get the front-end running from the substrate-interact dir. But I'm not sure where I'm supposed to be entering the extrinsics in the coretime-chain-setup. Also yarn test doesn't seem to be working in any of the directories.

substrate-interact

@keeganquigley
Copy link
Contributor

keeganquigley commented Nov 8, 2023

Also, deliverable 2b. links to a Figma prototype of the existing website. But the application states that an initial prototype of the coretime marketplace would be delivered for M1, based on the mockups in the proposal.

@poppyseedDev
Copy link
Contributor Author

Also, deliverable 2b. links to a Figma prototype of the existing website. But the application states that an initial prototype of the coretime marketplace would be delivered for M1, based on the mockups in the proposal.

Thank you for your message and the opportunity to clarify the deliverables. I've made some updates to the README to help differentiate between the various states of our application:

What is featured on the lastic website currently is the stable branch. This branch does not have all of the latest features, however the website presented there has been tested on different browsers, I am about to update that deliverable as well.

I linked the deployment that is featured on the main branch to test.lastic.xyz you can also view it by running the lasticUI locally and running it first with pnpm i and then pnpm run dev. Then for seeing the website you can navigate to localhost:3000 😊

@poppyseedDev
Copy link
Contributor Author

poppyseedDev commented Nov 10, 2023

Thanks @phillux much appreciated. Moving on, the substrate-interact repo instructions say to use yarn for the front-end, but the static_frontend repo says to use pnpm. Is there a reason for using both package managers? yarn install works but it gives a warning about mixing package managers:

yarn install v1.22.19
warning ../../package.json: No license field
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error @azns/resolver-core@1.6.0: The engine "node" is incompatible with this module. Expected version ">=16 <=18". Got "20.6.1"
warning @azns/resolver-core@1.6.0: The engine "pnpm" appears to be invalid.
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

And then yarn start fails:

yarn run v1.22.19
warning ../../package.json: No license field
$ next start
[Error: ENOENT: no such file or directory, open '/Users/keeganquigley/LasticUI/static_frontend/.next/BUILD_ID'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/keeganquigley/LasticUI/static_frontend/.next/BUILD_ID'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

pnpm run dev also fails:

pnpm run dev

> lastic@0.1.0 dev /Users/keeganquigley/LasticUI/static_frontend
> next dev

FatalError: error TS6046: Argument for '--moduleResolution' option must be: 'node', 'classic', 'node16', 'nodenext'.

    at getTypeScriptConfiguration (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/lib/typescript/getTypeScriptConfiguration.js:49:19)
    at writeConfigurationDefaults (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/lib/typescript/writeConfigurationDefaults.js:178:117)
    at verifyTypeScriptSetup (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/lib/verify-typescript-setup.js:119:74)
    at async verifyTypeScript (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:108:26)
    at async startWatcher (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:129:29)
    at async setupDevBundler (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:1627:20)
    at async initialize (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/router-server.js:71:30)
    at async Server.<anonymous> (/Users/keeganquigley/LasticUI/static_frontend/node_modules/.pnpm/next@13.5.6_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/lib/start-server.js:221:36)

Can you help me look into this? I'll try on Ubuntu as well. Should I be using the main branch?

Thanks for bringing this to our attention. We've made some updates to streamline the package management process across our repositories. Now, both the substrate-interact and static_frontend directories are aligned to use pnpm as the package manager. Here's how you can proceed:

  1. Unified Package Management:

We've standardized the use of pnpm for both directories to avoid inconsistencies and potential conflicts between package managers.
This change should resolve the warnings and errors you encountered with yarn.

  1. Running the Projects:
    You can now execute both projects from the master directory (lastic_ui). Alternatively, if you prefer, you can also run them individually by navigating into their specific directories (lastic_ui/substrate_interact or lastic_ui/static_frontend).
    The commands to run the projects remain the same as detailed in the README.md:
    Run pnpm i to install dependencies.
    Then, execute pnpm run dev to start the development server.

  2. Additional Step for substrate_interact:

For running the substrate_interact, you'll also need to have the Substrate node running.
You can start the Substrate node by executing the ./start.sh script.

  1. For additional instrcutions

For additional instrcutions on how to interact with substrate interact I provided documentation available on the docs.lastic.xyz under substrate-interact/index and substrate-interact/interact

  1. Future Plans for substrate_interact:

It's worth noting that substrate_interact is currently used primarily as a tool for internal testing of chain interactions.
We're planning to migrate these functionalities to an lastic-sdk in the near future, which should offer a more streamlined experience.

I hope this resolves your issues. If you're still encountering problems, feel free to reach out. We appreciate your efforts in setting up Lastic and are here to assist with any further queries or concerns you might have.

 - added testing details
 - improved documentation
 - improved clarity
@poppyseedDev
Copy link
Contributor Author

Hi @poppyseedDev I started my evaluation today and have the following initial comments:

  • The proposal states that "core functions will be fully covered by comprehensive UI testing framework" but the deliverable is blank. I know that it is all mock data but shouldn't there still be some tests here?

I have updated the milestones and tried to add more clarity to our overall documentation. Therefor I have provided additional testing instructions that found in the deliverables file under testing-guide.

@poppyseedDev
Copy link
Contributor Author

poppyseedDev commented Nov 13, 2023

Hey @keeganquigley added everything needed, please let us know if you are able to run it now.

@keeganquigley
Copy link
Contributor

Thanks @poppyseedDev sorry I was out Friday, looking at the updates now.

@keeganquigley
Copy link
Contributor

Thanks for your hard work @poppyseedDev @phillux and thanks for resolving the issues. The docs look amazing now too. I am now able to get through all the testing guides, and run the chain & app locally as well as on the test Vercel site. Here is my final evaluation. Please note a few minor issues.

Great work! I'm excited to see the coretime marketplace come to life and looking forward to seeing an initial implementation. I'm happy to pass the milestone, and congrats! Please expect up to 14 days for payment once your invoice is submitted.

@keeganquigley keeganquigley merged commit 1fa39f1 into w3f:master Nov 13, 2023
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@phillux
Copy link
Contributor

phillux commented Nov 14, 2023

@keeganquigley we have submitted the invoice using the invoice form.

thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants