Aisland docsig milestone 2

[poseidon-aisland]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• [x ] This pull request is being made by the same account as the accepted application.
• [ x] I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• [x ] In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• [ x] The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1853 < please fill this in with the PR number of your application.

[nikw3f]

Hello @poseidon-aisland I am getting this error while running tests:

/Users/nikhil/w3f/docsig/node_modules/mysql2/promise.js:112
const localErr = new Error();
^

Error: Unknown column 'private' in 'where clause'
at PromiseConnection.execute (/Users/nikhil/w3f/docsig/node_modules/mysql2/promise.js:112:22)
at /Users/nikhil/w3f/docsig/docsig-server.js:1057:45
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
code: 'ER_BAD_FIELD_ERROR',
errno: 1054,
sql: "select * from templates where private='N' or creator=? order by description",
sqlState: '42S22',
sqlMessage: "Unknown column 'private' in 'where clause'"
}

Seems like schema is not up to date

[poseidon-aisland]

Sorry for the issue, I've updated the databases schema for docker and tested it well, I've updated the repo accordingly. There is also a new variable that may be necessary to update in case of use behind a reverse proxy. The README has been updated to explain it.
There is still something to fix on the unit test. I will update later.

[poseidon-aisland]

I've updated the unit tests as well, for what I see everything is ok.

[poseidon-aisland]

can I help in doing something more?

[nikw3f]

Hey team, tests still not passing.

server stops on.

TypeError: Bind parameters must not contain undefined. To pass SQL NULL specify JS null
    at /Users/nikhil/w3f/docsig/node_modules/mysql2/lib/connection.js:664:17
    at Array.forEach (<anonymous>)
    at Connection.execute (/Users/nikhil/w3f/docsig/node_modules/mysql2/lib/connection.js:656:22)
    at /Users/nikhil/w3f/docsig/node_modules/mysql2/promise.js:121:11
    at new Promise (<anonymous>)
    at PromiseConnection.execute (/Users/nikhil/w3f/docsig/node_modules/mysql2/promise.js:118:12)
    at /Users/nikhil/w3f/docsig/docsig-server.js:1238:45
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

on test ● Api - Update Document Counterpart
Please fix all the tests

[nikw3f]

Tests are running fine after this fix:

patch:

diff --git a/docsig-server.js b/docsig-server.js
index b6628da..da16de9 100644
--- a/docsig-server.js
+++ b/docsig-server.js
@@ -411,7 +411,7 @@ async function mainloop() {
     const documentid = req.query.documentid;
     const pdf = req.query.pdf;
     const pt = req.query.pt; // public view token
-    const blob64=req.query.blob //blob if available from the blockchain
+    const blob64=req.query.blob64 || ""; //blob if available from the blockchain
     console.log("blob64",blob64);
     // check security token
     if (typeof token === "undefined" && typeof pt === "undefined") {
@@ -1176,7 +1176,7 @@ async function mainloop() {
   app.get("/updatedocumentcounterpart", async function (req, res) {
     // parameters required
     const token = req.query.token;
-    const signaturetoken = req.query.signaturetoken;
+    const signaturetoken = req.query.signaturetoken || null;
     const account = req.query.account;
     const documentid = req.query.documentid;
     const documentaccount = req.query.documentaccount;

[nikw3f]

Thanks for the delivery @poseidon-aisland. You can find my finished evaluation here. Happy to pass the milestone.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[github-actions]

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!