FiDi DotSight Milestone 1

[fidiroman]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1748

[keeganquigley]

Update for transparency: Changed PR Link to Application Document in order to correctly parse it.

[keeganquigley]

Thanks for the delivery @fidiroman will take a look at it shortly.

[keeganquigley]

Hi @fidiroman sorry for the delay, and congrats on being PR 1000 :) Here is my initial evaluation.

The Nest application runs successfully and all tests pass, but I'm a bit confused when it comes to the provided DeBank and SubSquid examples. When I run the GET command with cURL I get a parsing error:

curl -X GET /pipelines/polkadot-coin/execute?mapperIds[]=dot-value-distribution&walletIds[]=16ZL8yLyXv3V3L3z9ofR1ovFLziyXaN1DPq4yffMAZ9czzBD&walletIds[]=12xtAYsRUrmbniiWQqJtECiBQrMn8AypQcXhnQAc6RB6XkLW&currencies[]=eth&currencies[]=usd
zsh: parse error near `&'

I see that pipeline.config.ts already has both pipelines imported, so what should I be updating here? The docs are great up to this point, but I wonder if perhaps you provide some different solutions for how to run the examples? Thanks!

[fidiroman]

Excellent call out, thanks @keeganquigley! There should be some quotes in that query; surprised that our initial testers didn't catch that earlier. I just updated the docs, added more usage examples and called out the need for specifying the host/port for local deployments, e.g., just ran successfully

curl "localhost:3000/pipelines/polkadot-coin/execute?mapperIds[]=dot-value-distribution&walletIds[]=16ZL8yLyXv3V3L3z9ofR1ovFLziyXaN1DPq4yffMAZ9czzBD&walletIds"

Let us know if anything else stands out, we appreciate your feedback!

[keeganquigley]

Awesome thanks for making the fixes @fidiroman everything is working great now. My final eval is here and the milestone is hereby accepted. Nice work! Looking forward to the next milestone.

[Polkadot-Forum]

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-digest-26-sep-2023/4041/1

[RouvenP]

hi @fidiroman we transferred the payment today