diff --git a/evaluations/Solang_Playground_2_dsm-w3f.md b/evaluations/Solang_Playground_2_dsm-w3f.md index aeb509619..267c3381f 100644 --- a/evaluations/Solang_Playground_2_dsm-w3f.md +++ b/evaluations/Solang_Playground_2_dsm-w3f.md @@ -10,9 +10,68 @@ | ------ | ----------- | -------- | ---- |----------------- | | *0a.* | License | | | | | *0b.* | Documentation | | | Missing some instructions | -| *0c.* | Testing and Testing Guide | | | Missing instructions | -| *0d.* | Docker | | | Missing instructions and couldn't run sucessfully | -| 1. | Initial skeleton | | -Repo: https://labs.hyperledger.org/solang-playground/ .
-Demo: https://drive.google.com/file/d/1NmuBdEieE54ojBB_axXifcLNctv-KSWW/view
-amd64 docker image: https://hub.docker.com/repository/docker/tareknaser360/solang-playground-amd64/general .
hosted editor (for easier testing purposes): http://labs.hyperledger.org/solang-playground/ | | +| *0c.* | Testing and Testing Guide | | | | +| *0d.* | Docker | | | Missing instructions to run the container, couldn't run sucessfully | +| 1. | Initial skeleton | | -Repo: https://github.com/hyperledger-labs/solang-playground
-Demo: https://drive.google.com/file/d/1NmuBdEieE54ojBB_axXifcLNctv-KSWW/view
-amd64 docker image: https://hub.docker.com/repository/docker/tareknaser360/solang-playground-amd64/general .
hosted editor (for easier testing purposes): http://labs.hyperledger.org/solang-playground/ | | + +## Evaluation V2 + +### Documentation + +The documentation was improved but the instructions to run the docker container are missing. + +### Docker + +We installed the Sysbox following [these instructions](https://github.com/nestybox/sysbox/blob/master/docs/user-guide/install-package.md#installing-sysbox). The documentation is still missing the command to run the container. We tried to run it without success using the command `docker run --runtime=sysbox-runc solang-playground` after building the image. See the logs below, it runs but gets frozen with these logs. + +``` +user@localhost:~/Documents/w3f/solang-playground$ docker run --runtime=sysbox-runc solang-playground +latest: Pulling from hyperledger/solang +c83baea2d576: Pulling fs layer +650bb573ec30: Pulling fs layer +c83baea2d576: Verifying Checksum +c83baea2d576: Download complete +c83baea2d576: Pull complete +650bb573ec30: Verifying Checksum +650bb573ec30: Download complete +650bb573ec30: Pull complete +Digest: sha256:7131eb2cd1572e8852a3ce6290828655d4256a34880096c76746dd16722d7731 +Status: Downloaded newer image for ghcr.io/hyperledger/solang:latest +ghcr.io/hyperledger/solang:latest +``` + +### Testing + +The instructions to run the tests were added. Before, we ran using the command `npm test` but now we run using the command `cargo make test`. It runs one more test. + +``` +[cargo-make] INFO - Running Task: test-backend + + Running tests/server_tests.rs (target/debug/deps/server_tests-431164c904b3e777) + +running 1 test +test tests::language_server_workflow ... ok + +test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s + +[cargo-make] INFO - Running Task: test-app + +> monaco-lsp-streams@0.0.0 test +> jest + + PASS tests/api.test.ts (9.872 s) + Ensuring the server serves the built frontend + ✓ Verifying a successful response upon making a request (32 ms) + Ensuring the server’s compile endpoint is operational + ✓ Verifying a successful compile request (8226 ms) + +Test Suites: 1 passed, 1 total +Tests: 2 passed, 2 total +Snapshots: 0 total +Time: 9.932 s +Ran all test suites. +[cargo-make] INFO - Build Done in 11.40 seconds. +``` ## Evaluation V1 @@ -41,11 +100,12 @@ user@localhost:~/Documents/w3f/solang-playground$ cargo make run We tested it manually by doing the same thing on the [demo video](https://drive.google.com/file/d/1NmuBdEieE54ojBB_axXifcLNctv-KSWW/view). -image 1 +![image (59)](https://github.com/dsm-w3f/Grant-Milestone-Delivery/assets/112647953/985117fa-d26d-451e-801e-8a8853044524) + After adding the `flip( )` on line 18 it returned the compilation error on the message trace. -image 2 +![image (60)](https://github.com/dsm-w3f/Grant-Milestone-Delivery/assets/112647953/7a1eeef6-e9f4-43e0-9f3b-9f1449b61931) We have done some other small examples. It worked as expected. @@ -53,20 +113,15 @@ We also ran the automated test using the command `npm test` and the tests were s ``` user@localhost:~/Documents/w3f/solang-playground$ npm test - > test > npm run test --workspaces - - > monaco-lsp-streams@0.0.0 test > jest - PASS tests/api.test.ts (15.193 s) Ensuring the server serves the built frontend ✓ Verifying a successful response upon making a request (45 ms) Ensuring the server’s compile endpoint is operational ✓ Verifying a successful compile request (12480 ms) - Test Suites: 1 passed, 1 total Tests: 2 passed, 2 total Snapshots: 0 total