-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec review for Animation.progress #994
Comments
Hi @DavMila - just a quick question: you've indicated "CSS working group" as where this work is being done. However it doesn't seem to be in the CSS repo... is this an official CSS working draft or is it that the intention is to submit it to the CSS working group? Thanks! ✨ |
Thanks for the question. It's in the web-animations-2 spec in the official CSSWG repository for editor's drafts of CSS specifications . I don't think the web-animations-2 spec has been published as a working draft so it's still an editor's draft. So it has been submitted to the CSS working group as part of an editor's draft but not yet a working draft. |
After a discussion in a breakout: The explainer doesn't justify this feature well enough. It presents two use cases: one for showing a percentage through a time-based animation, and another for showing a scroll percentage. The time-based animation has two issues:
The scroll percentage code doesn't show the "before" state. What would the code look like if you only used It's possible but complicated to render text directly from an animated property: https://dev.to/madsstoumann/clocks-countdowns-timing-in-css-and-javascript-554n. Maybe the use cases for Finally, if you do need a property for this, it seems confusing to have two |
I've updated the explainer to address some of the concerns raised by @jyasskin .
The interest in a progress accessor was mainly driven by scroll-driven animations but it does seem to be a concept that would be valid for time-driven animations as well so I've set up a demo showing a more useful scenario: where a dev might want to synchronize audio based on the progress of an animation . I've also:
About the name of the property, I agree that it could be confusing, maybe a name like Further feedback appreciated :) |
@tabatkins, does w3c/csswg-drafts#6245 (comment) affect this review? |
No, completely unrelated name clash. |
Thank you for the fleshed out use cases in the explainer. We agree that it makes sense to be able to pass this value through Javascript to feed it into any parts of the platform that can't be directly animated by CSS. Thank you also for driving the CSSWG to pick a clearer name. With that done, we don't see any other issues with this proposal, so we'll close this review. Thanks! |
こんにちは TAG-さん!
I'm requesting a TAG review of Animation.progress.
This feature adds a "progress" property to the JavaScript class Animation. The goal of this property is provide authors a convenient and consistent representation of how far along an animation has advanced across its iterations and regardless of the nature of its timeline.
Further details:
The text was updated successfully, but these errors were encountered: