From dc4d6f15a2ab931d70391da26b3cc548c25a600d Mon Sep 17 00:00:00 2001 From: James Nord Date: Mon, 22 Feb 2021 12:16:26 +0000 Subject: [PATCH 1/2] clarify the bahaviour of beforeunloaded prompts The wording of the current entry implies to some that promots from beforeunloaded are always dismissed and thus the promot is in effect never shown and the user will have no chance to interact with it. This interpretation would lead it to be impossible to interact with them and test them - which seems to be the purpose of the webdriver spec, so this would imply that that interpretation is incorrect. This clarifies the wording to say that the promot is dismissed on *subsequent* navigations, thus if a prompt was shown and a navigation attempt was performed then it would be dismissed, however if the cause of the alter was a navigation then the promot will be shown so that the user can interact with it. fixes #1294 --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 9cba7da8..e3f23b84 100644 --- a/index.html +++ b/index.html @@ -9730,8 +9730,8 @@

User prompts

User prompts that are spawned from beforeunload event handlers, - are dismissed implicitly upon navigation - or close window, + are dismissed implicitly upon a subsequent navigation + or a subsequent close window, regardless of the defined user prompt handler.

A user prompt has an associated user prompt message From 5d22ffa553a403b015e76ed55b994c31f42e780e Mon Sep 17 00:00:00 2001 From: James Nord Date: Mon, 22 Feb 2021 14:17:46 +0000 Subject: [PATCH 2/2] Fix the incorrect link to navigation The "navigation" used in versions of the spec from 33c1f38f5353ffd3033179bd698b2adf84f41e86 used to link to "Go". The previous commit attempted to fix this by removing the link and linking to the generic navigation definition however this was not the intent. SO this was originally introduced in #1040 this fixes this and so now correctly shows when prompts from beforeunload should be implicitly dismissed --- index.html | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/index.html b/index.html index e3f23b84..bf2c2d55 100644 --- a/index.html +++ b/index.html @@ -9730,9 +9730,8 @@

User prompts

User prompts that are spawned from beforeunload event handlers, - are dismissed implicitly upon a subsequent navigation - or a subsequent close window, - regardless of the defined user prompt handler. + are dismissed implicitly upon a navigation + or a close window, regardless of the defined user prompt handler.

A user prompt has an associated user prompt message that is the string message shown to the user,