Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[Get]] method doesn't exist in CredMan #2169

Open
emlun opened this issue Oct 1, 2024 · 2 comments
Open

[[Get]] method doesn't exist in CredMan #2169

emlun opened this issue Oct 1, 2024 · 2 comments

Comments

@emlun
Copy link
Member

emlun commented Oct 1, 2024

§5.1.4. Use an Existing Credential to Make an Assertion - PublicKeyCredential’s [[Get]](options) Method appears to reference a [[Get]] internal method on the Credential interface from CredMan, but no such internal method exists (unlike [[Create]], which does exist). Rather, [[DiscoverFromExternalSource]] is the actual internal method we override.

Proposed Change

@emlun emlun self-assigned this Oct 1, 2024
@emlun
Copy link
Member Author

emlun commented Oct 1, 2024

The [[Get]] was added in commit 46d6c51 in PR #672. The reason appears to have been for consistency with §5.1.3. Create a New Credential - PublicKeyCredential’s [[Create]](origin, options, sameOriginWithAncestors) Method. "Use an existing credential to make an assertion" already had a "[[DiscoverFromExternalSource]]" sub-heading; the reason this was (and still is) a sub-heading appears to be because "Use an existing credential to make an assertion" refers to both [[DiscoverFromExternalSource]] and [[CollectFromCredentialStore]] and how they interact.

@nadalin nadalin added this to the L3-WD-02 milestone Oct 2, 2024
@emlun
Copy link
Member Author

emlun commented Oct 2, 2024

2024-10-02 WG call: hearing no objections to this. @emlun to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants