Exclude all platform authenticators that use self attesation from hav… #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to use none attestation
|
I carelessly modified my local fork causing two unrelated commits to be part of this PR. Only commit d7e238e should be part of this PR. If needed, I can close this PR and open a new one. |
|
You can force push to zacknewman:main to change the contents of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing to use none attestation
Closes #2146
Related #1962
#2146 raises the possibility of leaving attestation for all platform authenticators based on the argument that much of the information related to attestation could be re-generated once AAGUID is known (which all platform authenticators keep); however this PR more conservatively only excludes platform authenticators that use self attestation since self attestation does not contain any new information and self attestation is already excluded from being replaced with none when the AAGUID is already all zero (i.e., RPs, even ones that only intend to support none attestations, have to be prepared to handle via error the possibility of receiving self attestation despite requesting none).
The following tasks have been completed:
Implementation commitment:
Documentation and checks
- [ ] Affects privacyThis PR only affects self attestation which doesn't contain any data not already known by the RP.- [ ] Affects security- [ ] Updated explainer (linkPreview | Diff