Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!] Consider adding contents list (TOC of h2s) to country pages #345

Open
shawna-slh opened this issue Nov 29, 2018 · 11 comments
Open

[!!] Consider adding contents list (TOC of h2s) to country pages #345

shawna-slh opened this issue Nov 29, 2018 · 11 comments
Assignees
Labels
complex change that is difficult or time consuming user interface waiting

Comments

@shawna-slh
Copy link
Contributor

use case: user goes to https://www.w3.org/WAI/policies/united-states/

  • cannot easily tell how many listings are on the page, nor get to a specific one.
  • would increase usability and accessibility if could see list of all, and be able to easily jump to specific ones.

let me know if you want more use case, rationale, or other perspectives -- or if there are reasons not to add the TOC

thanks

@yatil
Copy link
Contributor

yatil commented Nov 29, 2018

ok for me

waiting on approval/feedback on #285 for implementation & publication

@yatil yatil added the waiting label Nov 29, 2018
@bakkenb
Copy link

bakkenb commented Nov 29, 2018

+1 to TOC

How would this be handled? TOC on every country page even if only one record available? Or only added to countries that have states, provinces, etc.?

Obviously it would be helpful in the example pointed to of the United States even though that is not the "state specific" page but the country page in general. I think TOC is useful in all locations.

@yatil yatil self-assigned this Nov 30, 2018
@yatil
Copy link
Contributor

yatil commented Nov 30, 2018

We could say have a TOC when:

  • at least three policies are available OR
  • when there’s at least one policy and there is states data

(This raises the question of needing an inner-state TOC.)

Another idea would be to use expand/collapse instead of the boxes, but that would be quite some redesign (= what do we want them to see immediately, what after the disclosure opens…)

@bakkenb
Copy link

bakkenb commented Nov 30, 2018

+1 to @yatil two bullet ideas above
-1 to expand/collapse

@shawna-slh
Copy link
Contributor Author

I also thought about both options. (great minds think alike :-)

Agree not to do expand/collapse, especially because "that would be quite some redesign".

I was going to suggest that the TOC is only visible if there is more than one listing... but then I thought about the fact that even when there is only one, you still cannot tell that without scrolling. So I [mildly] think we should just always have a TOC. (Also a bit simpler coding. :-)

@bakkenb
Copy link

bakkenb commented Dec 7, 2018

TOC always there brings consistency too.

@yatil
Copy link
Contributor

yatil commented Dec 7, 2018

OK.

@iamjolly iamjolly added the simple change that is easy, quick, or otherwise straightforward label Mar 12, 2019
@iadawn iadawn assigned iadawn and unassigned yatil, sharronrush, AndrewArch and bakkenb Jun 6, 2023
@iadawn iadawn removed the simple change that is easy, quick, or otherwise straightforward label Jun 6, 2023
@iadawn iadawn added the complex change that is difficult or time consuming label Jul 4, 2023
iadawn added a commit that referenced this issue Jul 4, 2023
@iadawn
Copy link
Contributor

iadawn commented Jul 4, 2023

@shawna-slh Pulled together how this might look

Including TOC as a box at the top meant that the 'boxed' approach to presenting each policy started to look problematic. I have removed that to avoid the page looking too cluttered.

@shawna-slh
Copy link
Contributor Author

I think having each policy in a box is much better usability. And follows the design pattern of course list and other such listings.

If too boxy, I think removing the Page Contents box probably better.

And, I don't think it's a big deal either way, and I'm OK removing the boxes if you and others (e.g., @brianelton ) prefer.

@iadawn
Copy link
Contributor

iadawn commented Jul 25, 2023

Having all the boxes is extremely boxy. I would disagree that removing the Page Contents box is better. That is a consistent pattern across the entire site, doing something different here would be much more jarring. Having a different approach from Course List would be less problematic since jumping between course list and policies is less likely.

Note that the presentation of state information is not boxed at all. This is currently minor as there are few instances of this.

I have mocked up a sample page with all the boxes: United States with TOC and boxes

@brianelton
Copy link

Any other page in the WAI site that has a summary/page contents box at the top does not have the rest of the content in boxes, so I think removing the boxes falls in line. I vote for including the page contents in a box and having the rest of the content without a box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complex change that is difficult or time consuming user interface waiting
Projects
None yet
Development

No branches or pull requests

8 participants