Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid credentialSchema.id for JsonSchemaCredential #238

Open
antonio-ivanovski opened this issue Nov 29, 2024 · 1 comment
Open

Invalid credentialSchema.id for JsonSchemaCredential #238

antonio-ivanovski opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@antonio-ivanovski
Copy link

The spec suggests that credentialSchema of JsonSchemaCredential VC doc be of this predefined value:

{
  "id": "https://www.w3.org/ns/credentials/json-schema/v2.json",
  "type": "JsonSchema",
  "digestSRI": "sha384-S57yQDg1MTzF56Oi9DbSQ14u7jBy0RDdx0YbeV7shwhCS88G8SCXeFq82PafhCrW"
}

Fetching https://www.w3.org/ns/credentials/json-schema/v2.json gives the following schema for the credentialSchema field

"credentialSchema": {
  "type": "object",
  "properties": {
    "id": {
      "type": "string",
      "const": "https://www.w3.org/2022/credentials/v2/json-schema-credential-schema.json"
    },
    "type": {
      "type": "string",
      "const": "JsonSchema"
    },
    "digestSRI": {
      "type": "string"
    }
  },
  "required": [
    "id",
    "type",
    "digestSRI"
  ]
}

This makes the schema itself invalid, namely:

@decentralgabe
Copy link
Collaborator

Thanks @antonio-ivanovski are you able to open a PR addressing this?

@decentralgabe decentralgabe added the bug Something isn't working label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants