Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change embed to isolate in example. #1198

Open
r12a opened this issue Jan 23, 2020 · 5 comments
Open

Change embed to isolate in example. #1198

r12a opened this issue Jan 23, 2020 · 5 comments
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Milestone

Comments

@r12a
Copy link

r12a commented Jan 23, 2020

10.2.12 tts:direction
https://w3c.github.io/ttml2/index.html#style-attribute-direction

The tts:direction style is illustrated by the following example.

<p> The title of the book is "<span tts:unicodeBidi="embed" tts:direction="rtl">نشاط التدويل، W3C</span>" </p>

It is recommended to always use isolating bidi controls, rather than embedding, since it solves many problems for RTL scripts.

Therefore we recommend an editorial change to this example, to encourage good usage: change tts:unicodeBidi="embed" to tts:unicodeBidi="isolate".

@r12a r12a added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label Jan 23, 2020
@nigelmegitt
Copy link
Contributor

Since this is editorial I think we could consider this change before transitioning to 2nd Ed PR. @skynavga what do you think?

@skynavga skynavga added this to the 3ED milestone Jan 23, 2020
@skynavga skynavga changed the title Change embed to isolate in example Change embed to isolate in example. Jan 23, 2020
@skynavga
Copy link
Collaborator

@nigelmegitt no, I do not agree; this requires further discussion; furthermore, the recent addition of isolate value is not reflected in current TTML/IMSC implementations;

@r12a
Copy link
Author

r12a commented Jan 23, 2020

It's an example. I wouldn't have thought this change would be problematic, since the spec allows one to do this. One would hope that changing the example would have the effect of encouraging people to implement support for that value, if nothing else. It's certainly desirable to isolate spans in bidrectional text.

@skynavga
Copy link
Collaborator

@r12a my primary concern is that the addition of isolate is a very recent change with generally unknown implementation support; the current value is not technically incorrect, so I would prefer leaving it in place for the time being, and we can revisit this issue at a future point without prejudice;

@r12a
Copy link
Author

r12a commented Jan 27, 2020

I still think you should be encouraging good practice rather than bad in examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Projects
None yet
Development

No branches or pull requests

3 participants