Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server_ip is likely not defined correctly. #120

Open
MattMenke2 opened this issue Nov 26, 2019 · 1 comment
Open

server_ip is likely not defined correctly. #120

MattMenke2 opened this issue Nov 26, 2019 · 1 comment

Comments

@MattMenke2
Copy link

The spec defines "server_ip" as "The IP address of the server to which the user agent sent the request, if available. Otherwise, an empty string." Yet in Example 10, server_ip is set in the case a request was not sent due to not being able to establish a connection. While examples are typically non-normative, I suspect in this case it's the example that's correct, and server_ip should not be empty even in the case no request was actually sent.

@MattMenke2
Copy link
Author

A related issue - if we're unable to establish a TCP connection at all, then multiple IPs will be tried. If a hostname maps to 5 IP addresses, and they all fail, what should server_ip be? The first one we tried? The last one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant