Editorial: Handle PRs from forks #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
daniel-montalvo
changed the title
|
I was hoping we could run a prettier check before trying to write. That way, we can ask external PR authors to run prettier locally to pass the check, avoiding the write access problem. |
spectranaut
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks for this, Daniel, but I agree with @pkra ! It would be better if we did a prettier dry run on forks and if it fails, ask the person who made the PR to run prettier locally.
From a quick look it looks like a possibility: https://github.com/marketplace/actions/prettier-action
spectranaut
previously approved these changes
Aug 19, 2024
spectranaut
changed the title
|
I think this now matches your suggestions. |
MelSumner
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294