chore: Adds cspell config #402
Conversation
mohamedamir
left a comment
mohamedamir
left a comment
There was a problem hiding this comment.
Good call!
Thank you, TIm!
SHA: 61739d8 Reason: push, by timcappalli Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Please don't merge stuff until I've also had a chance to review it. 🙏 We should be running this on the GitHub sever (pre-commit check)... this is not something I have locally and it's not documented how to actually use it in the CONTRIBUTING.md, for instance. |
|
It was administrative and did not require all 3 editors approval. CSpell is not something you have to install. it is built-in to nearly every modern editor, which pick up the config automatically. Catching spelling errors while working client side is also a good thing. |
I think you might have to for VS Code: That's what I'm reading. Is that correct? |
|
Ok, but also, see your PR here: Updates the cspell files. That's the bit I'm concerned about too... adding cspell adds stuff to the workflow, because otherwise we will get out of sync or still introduce typos unless all the editors are using cspell. Let me get @copilot to add something to #405 that amends the CONTRIBUTNG.md with instructions to install the extension. |
|
Ok, updated #405 . I've installed cspell extension locally to work with VS Code. |
No description provided.