-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Presentation Exchange Example #7
Comments
@OR13 oh, very cool, thanks! Will take a look. |
Would a
|
@mavarley this would be a great one for you to answer. |
Hi @jrhender I believe the TrustBloc project has a sample of using PE within the VPR (which is the protocol currently spec'd in both CHAPI and some of the VC API examples) and I will attach that when I can locate it :) Part of the |
@mavarley You linked to an example from the TrustBloc project here: w3c-ccg/vc-api#174 (comment) (here is the link for reference: https://github.com/trustbloc/wallet/blob/main/test/mock/adapter/templates/webWallet.html#L567-L643 ) If so, it seem what TrustBloc has done is a VPR credential query that looks like
Comparing that to what I suggested above:
@mavarley Is this an accurate comparison in your view? Regarding
I think it is still valuable to continue the discussion of how to include a |
hi @jrhender ; is the intention of making the I am inviting @rolsonquadras and @sudeshrshetty to participate, as they did the TrustBloc implementation. |
@jrhender @mavarley TrustBloc supports both variant of credential queries, single object or array.
and
we followed similar pattern in universal wallet Query interface & in this example The differences I see with your sample are |
@sudeshrshetty Thanks for the clarification on single object vs array. I know my example had array, but I actually think that single object makes more sense. I'm curious if you had a use case where the array (with multiple presentation definitions) was useful?
I agree that these are the differences. Regarding Regarding
|
The group discussed this on the 2024-07-30 telecon: It is possible to convert VPR to Presentation Exchange if one would like to use a single VPR but also support OID4 over VC API Exchanges. It would be useful for the specification to define how to do that to ensure that readers know that you can run OID4 over VC API in a way where the organization deploying software only needs to write a query in VPR to be able to support both VC API Exchanges and OID4. An example of code that already does that is here: https://github.com/digitalbazaar/oid4-client/blob/main/lib/oid4vp.js#L298-L380 A PR should be raised that defines the algorithm to convert a VPR to a Presentation Exchange. |
It seems as if Presentation Exchange is going to be deprecated in OID4 v1.1 and beyond. This issue has been overtaken by events. Demonstrating an example for a request language that's being deprecated in VPR doesn't make sense. Examples using the new query language will be done via the PR to address issue #22. Marking this issue as pending close. |
@msporny thanks for the above update. A couple questions:
|
It is doubtful that PE will continue to be used anywhere. It was a complicated spec to start and the community has learned a number of lessons on what not to do with a query language since then. While it's true that PE might live on, there don't seem to be many in the community that are willing to put in the time and effort to take it standards track. I do expect bits and pieces of it to live on in other query languages, though.
It means that there is no standards-track effort that has has committed to progressing PE at this point in time, so putting an example in this specification for something that isn't going to reach standards status is going to mislead developers on the proper usage of the specification. |
https://github.com/decentralized-identity/presentation-exchange
https://identity.foundation/presentation-exchange/#chapi
essentially, the request query is a special type, and the response is an extended VP...
Examples and cross linking would be helpful.
The text was updated successfully, but these errors were encountered: