Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

414 problem details response #418

Merged
merged 15 commits into from
Oct 22, 2024
Merged

414 problem details response #418

merged 15 commits into from
Oct 22, 2024

Commits on Sep 10, 2024

  1. add ProblemDetails object, modify verify credential options and response 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8845768 View commit details
    Browse the repository at this point in the history

  2. fix typo 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3812669 View commit details
    Browse the repository at this point in the history

  3. fix linting issue bool to boolean 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    da8e436 View commit details
    Browse the repository at this point in the history

  4. add ProblemDetails example 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a109d8e View commit details
    Browse the repository at this point in the history

  5. improve validity fields results 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8bf6848 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Apply suggestions from code review 

    An issue was also mentioned about the error type `https://www.w3.org/TR/vc-data-model#PARSING_ERROR` not resulting in any meaningful destination/description.

Co-authored-by: Ted Thibodeau Jr <[email protected]>
    @PatStLouis @TallTed
    PatStLouis and TallTed authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0a321b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Replace occurences of warnings/errors with problemDetails 

    Since warning and errors are designed to be an array of ProblemDetails objects, it would simplify to combine these 2 properties into a single problemDetails array in some cases.

Co-authored-by: Manu Sporny <[email protected]>
    @PatStLouis @msporny
    PatStLouis and msporny authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7d0214d View commit details
    Browse the repository at this point in the history

  2. Apply linting suggestions from code review 

    Co-authored-by: Dave Longley <[email protected]>
    @PatStLouis @dlongley
    PatStLouis and dlongley authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6199f52 View commit details
    Browse the repository at this point in the history

  3. Add a warning about the ProblemDetails type URL pending VCDM 2.0 beco… 

    …ming a global standard.

Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    338586d View commit details
    Browse the repository at this point in the history

  4. replace occurence of the property details for message in the response… 

    …s to disambiguate form the problemDetails object

Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6f21128 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix linting and add problem detail object reference 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7e7c69e View commit details
    Browse the repository at this point in the history

  2. Apply suggestion 

    Co-authored-by: Ted Thibodeau Jr <[email protected]>
    @PatStLouis @TallTed
    PatStLouis and TallTed authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b93933e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. fix related object path for ProblemDetails 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1ba3797 View commit details
    Browse the repository at this point in the history

  2. Merge branch '414-problem-details-response' of github.com:w3c-ccg/vc-… 

    …api into 414-problem-details-response
    @PatStLouis
    PatStLouis committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    609b5da View commit details
    Browse the repository at this point in the history

  3. Apply some linting fix to the ProblemDetails schema 

    Signed-off-by: pstlouis <[email protected]>
    @PatStLouis
    PatStLouis committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d969201 View commit details
    Browse the repository at this point in the history