414 problem details response #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
PatStLouis
requested review from
msporny,
mavarley and
mkhraisha
as code owners
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
dlongley
reviewed
Sep 10, 2024
| description: The verified credential | ||
| example: { "checks": ["proof"], "warnings": [], "errors": [] } | ||
| description: The verified credential used as the verification payload. | ||
| example: { "verified": True, "results": {"credentialSchema": [], "credentialStatus": [], "proof": []}, "warnings": [], "errors": [] } |
There was a problem hiding this comment.
Suggested change
| example: { "verified": True, "results": {"credentialSchema": [], "credentialStatus": [], "proof": []}, "warnings": [], "errors": [] } | |
| example: { "verified": true, "results": {"credentialSchema": [], "credentialStatus": [], "proof": []}, "warnings": [], "errors": [] } |
Signed-off-by: pstlouis <[email protected]>
TallTed
suggested changes
Sep 11, 2024
jrhender
reviewed
Sep 16, 2024
An issue was also mentioned about the error type `https://www.w3.org/TR/vc-data-model#PARSING_ERROR` not resulting in any meaningful destination/description. Co-authored-by: Ted Thibodeau Jr <[email protected]>
dlongley
approved these changes
Sep 17, 2024
dlongley
reviewed
Sep 17, 2024
dlongley
reviewed
Sep 17, 2024
dlongley
reviewed
Sep 17, 2024
dlongley
reviewed
Sep 17, 2024
msporny
reviewed
Sep 17, 2024
msporny
reviewed
Sep 17, 2024
Since warning and errors are designed to be an array of ProblemDetails objects, it would simplify to combine these 2 properties into a single problemDetails array in some cases. Co-authored-by: Manu Sporny <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
…ming a global standard. Signed-off-by: pstlouis <[email protected]>
…s to disambiguate form the problemDetails object Signed-off-by: pstlouis <[email protected]>
TallTed
reviewed
Sep 24, 2024
Signed-off-by: pstlouis <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Signed-off-by: pstlouis <[email protected]>
…api into 414-problem-details-response
Signed-off-by: pstlouis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProblemDetailsobject.Preview | Diff