-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the distinction between exchangeId and localExchangeId #425
Comments
In short, an exchange has two IDs, a fully qualified one (full URL) and a relative one (just the "slug" or "path" part). I don't think we want two different properties in the data model of exchanges for this -- and that we just want the relative value to be returned, i.e., We will need a separate name to describe the relative ID when talking about it as a URL path parameter, however, because it needs to be distinguished from other slugs/path params like the relative workflow ID (which appears in the full exchange ID URL). We do need to fix up the YAML files that describe what information is returned when creating an exchange. I believe there should be an We need to settle on a name for what we're calling the "slug"/"path" thing that appears in the URL / routes as a local/relative identifier for the exchange. Maybe we even want to use "relative" in name for that. |
As this example is a single exchange, the exchange id should be the same in both participate calls. See issue #425 for discussion.
Ok, thanks for the clarification @dlongley . Your points make sense to me 👍 . I think then that the exchange example should adjusted to have the same |
As this example is a single exchange, the exchange id should be the same in both participate calls. See issue #425 for discussion.
The group discussed this on the 2024-10-22 call and believed that more text would need to be written, specifically the following two things need terms that we use consistently in the spec:
The group will need to have further discussions on this item on a future call. |
When calling Create Exchange, an
exchangeId
is returned. However, the Participate in an Exchange endpoint has alocalExchangeId
URL path parameter.Looking at the Exchange Example, my assumption is that the
Create Exchange
endpoint was only called once. I think this must be the case as there is a single workflowId123
and a workflow can only have single possible starting step.Therefore, on might expect there to be a single
exchangeId
for the interactions in the example. However, thelocalExchangeId
changes in the example from123
toabc
. I see the following possible explanations:localExchangeId
is intended to be different from theexchangeId
. In other words, a "local exchange" is essentially an instance of workflow step which is associated with the parent exchange. If this the case, it is unclear how thelocalExchangeId
is determined (e.g. by the Owner Coordinator to pass to the client of the exchange).localExchange
is the same asexchangeId
and the change from123
toabc
is a mistake.I think that further discussion and explanatory text on this point would be helpful for implementors of the workflow features.
The text was updated successfully, but these errors were encountered: