Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with CommunityToolkit.WinUI.Collection #52

Open
ghost1372 opened this issue Oct 31, 2024 · 4 comments
Open

Conflict with CommunityToolkit.WinUI.Collection #52

ghost1372 opened this issue Oct 31, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ghost1372
Copy link

i used AdvancedCollectionView in my project (latest version), then i installed your TableView library, and i get conflict errors:

The type 'AdvancedCollectionView' exists in both 'CommunityToolkit.WinUI.Collections, Version=8.2.0.0, Culture=neutral, PublicKeyToken=null' and 'WinUI.TableView, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'

I need to use AOT in my Apps and it seems that the bugs related to AOT have been fixed in the latest versions.
But it seems that AdvancedCollectionView is hardcoded in your library and we are forced to use your AdvancedCollectionView and we cannot use its newer versions.
so please fix it

@ghost1372 ghost1372 added the bug Something isn't working label Oct 31, 2024
@mcka-dev
Copy link

The bug is present in the latest version:

The type 'IAdvancedCollectionView' exists in both 'CommunityToolkit.WinUI.Collections, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null' and 'WinUI.TableView, Version=1.2.2.0, Culture=neutral, PublicKeyToken=null'

@w-ahmad
Copy link
Owner

w-ahmad commented Jan 3, 2025

is it fine if I rename the AdvancedCollectionView and ITableViewCollectionView to something else? I am asking because this code is from Community Toolkit.

@ghost1372
Copy link
Author

is it fine if I rename the AdvancedCollectionView and ITableViewCollectionView to something else? I am asking because this code is from Community Toolkit.

No, it is better to refrence communitytoolkit collection nuget package and remove this internal classes

@w-ahmad
Copy link
Owner

w-ahmad commented Jan 3, 2025

I wish I could, but the problem is I must modify it to my needs that doesn't fit for the communitytoolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants