Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T7184: Fix makefile target test #917

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

MPStudyly
Copy link
Contributor

@MPStudyly MPStudyly commented Feb 20, 2025

Change summary

Add --cpu 4 and --memory 8 args to target test, matching target for VPP tests, fixing smoketest runs due to VPP requiring additional resources.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7184

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Feb 20, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Feb 20, 2025
@MPStudyly MPStudyly changed the title Fix makefile target test T7184: Fix makefile target test Feb 20, 2025
@MPStudyly
Copy link
Contributor Author

Is there anything left for me to do to get this merged?

@sever-sever
Copy link
Member

sever-sever commented Feb 21, 2025

Is there anything left for me to do to get this merged?

Could you do “commit amend” with proper commit message format which should include the task number. And push force.
A similar like you have in PR title

Add `--cpu` and `--memory` args to target `test`, fixing smoketest runs due to VPP requiring additional resources
@sever-sever sever-sever merged commit c6bf02f into vyos:current Feb 22, 2025
3 checks passed
@MPStudyly MPStudyly deleted the patch-1 branch February 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

3 participants