Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6859: include EULA files in build type definitions #833

Open
wants to merge 2 commits into
base: current
Choose a base branch
from
Open

build: T6859: include EULA files in build type definitions #833

wants to merge 2 commits into from

Conversation

dmbaturin
Copy link
Member

Change Summary

Include EULA files in build type definitions so that they don't need to be added in a separate CI step.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Internal change.

Related Task(s)

Component(s) name

Build configs.

Proposed changes

How to test

Images build with --build-type development and --build-type release should have the correct EULA in /usr/share/vyos/EULA.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@dmbaturin dmbaturin requested a review from a team as a code owner November 8, 2024 11:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

❌
PR title does not match the required format

@dmbaturin dmbaturin force-pushed the T6859-eula-files branch 2 times, most recently from 75fec83 to 9617417 Compare November 8, 2024 12:44
c-po
c-po requested changes Nov 17, 2024
View reviewed changes
data/build-types/release.toml Outdated Show resolved Hide resolved
@c-po
Copy link
Member

c-po commented Nov 20, 2024

After comiting the suggestion this one should be squashed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees

@dmbaturin dmbaturin

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @c-po @sever-sever