Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T1416: T861: T3664: T3664: T2640: various cleanup commits #751

Merged
merged 7 commits into from
Sep 5, 2024
Merged

T1416: T861: T3664: T3664: T2640: various cleanup commits #751

merged 7 commits into from
Sep 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Sep 5, 2024 •
edited
Loading

Change Summary

During Secure Boot development a lot of small things were found and got cleaned up with this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
T1416: remove deprecated default-union-grub-entry
d50707b
@c-po
Makefile: T861: add possibility to pass CLI options to check-qemu-ins…
388efd9 
…tall

We can now pass any arbitrary option to the check-qemu-install script by
calling: make test -- --bar-option or make testc -- --foo-option

please note the -- which is not a typo but rather signals the end of options
and disables further option processing and passes the options down to the next
script.
@c-po
Docker: T861: fix warnings about latest ENV key=value syntax
3e9cda2
@c-po
telegraf: T3664: remove package dependency
f539219 
Telegraf is not a full VyOS feature with a proper dependency in place via
vyos-1x package. Drop this temporary dependency.
@c-po
build: T3664: remove unused psutil dependency
3170bca
@c-po
Makefile: T2640: fix PHONY typo
d851548 
Fix typo added in commit 499e8e1 ("Makefile: T2640: add helper to convert
ISO to OCI image to start a co…ntainer") should be PHONY over PHONE
@c-po
T4974: remove package openvpn-dco as it has a proper dependency via v…
6867177 
…yos-1x
@c-po c-po requested a review from a team as a code owner September 5, 2024 05:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit c319ca6 into vyos:current Sep 5, 2024
9 checks passed
@c-po c-po deleted the secure-boot-cleanup branch September 7, 2024 09:02
@jestabro
Copy link
Contributor

Note that the first commit above needs to be reverted:
#836
and consequently the file in question needs to be preserved when backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-po @jestabro @dmbaturin @sever-sever