Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhcp: T5846: Have separate DUID formatter hint #71

Merged
merged 1 commit into from
Dec 21, 2023
Merged

dhcp: T5846: Have separate DUID formatter hint #71

merged 1 commit into from
Dec 21, 2023

Conversation

indrajitr
Copy link
Contributor

@indrajitr indrajitr commented Dec 20, 2023 •
edited
Loading

Change Summary

Have separate custom DUID formatter hint for config shell.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

dhcp

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@indrajitr
dhcp: T5846: Have separate DUID formatter hint
18bdce6 
Have separate custom DUID formatter hint for config shell.
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team December 20, 2023 22:32
@vyosbot vyosbot requested a review from c-po December 20, 2023 22:32
@indrajitr indrajitr mentioned this pull request Dec 20, 2023
Merged
12 tasks
@c-po c-po merged commit f3e579e into vyos:current Dec 21, 2023
4 checks passed
@c-po
Copy link
Member

c-po commented Dec 21, 2023

@Mergifyio backport sagitta

@mergify Mergify
Copy link

mergify bot commented Dec 21, 2023 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Dec 21, 2023
Merged
c-po added a commit that referenced this pull request Dec 21, 2023
@c-po
Merge pull request #72 from vyos/mergify/bp/sagitta/pr-71
23b79df 
dhcp: T5846: Have separate DUID formatter hint (backport #71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@indrajitr indrajitr

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indrajitr @c-po