Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less escape e() causes problems #40

Open
digerata opened this issue Mar 12, 2012 · 9 comments
Open

Less escape e() causes problems #40

digerata opened this issue Mar 12, 2012 · 9 comments

Comments

@digerata
Copy link
Contributor

Using version: 2.0.1.2

I'm getting an error:

Sass::SyntaxError: wrong number of arguments (1 for 0) for `e' (in app/assets/stylesheets/base.css.sass)

/Volumes/Clank/Users/Mike/.rvm/gems/ruby-1.9.2-p290@socialply/gems/compass_twitter_bootstrap-2.0.1.2/stylesheets/compass_twitter_bootstrap/_mixins.scss:540:in `buttonBackground'

Browsing the file, I see 3 or so instances of a mixin: e(). Doing a search reveals that this is a less function for escaping the content. I'm not sure what the correct course of action is, but I commented out each use of e() to get working.

@elsom25
Copy link

elsom25 commented Mar 12, 2012

I'm pretty sure including the raw css within the e() function will include it - though I can't find reference material to confirm this.

On that note, I'm having issues with this too (haven't tried fixing it yet)

@elsom25
Copy link

elsom25 commented Mar 12, 2012

for a very quick fix, you can implement the missing function:

// temporary fix for compass_twitter_bootstrap
@function e($raw-css) {
    @return #{$raw-css}
}

@phaza
Copy link

phaza commented Mar 12, 2012

The thing is that the function isn't missing, but it was introduced in compass master a few days ago, and a new version of compass gem was pushed yesterday, and hence people are getting this error now.

I tracked it down to this commit in compass:
Compass/compass@3dc42c8#L3R19

I guess namespacing or renaming e() should suffice.

@kebot
Copy link

kebot commented Mar 13, 2012

I also had this problem.

@blackice2999
Copy link

Hi,

i think its safe to remove the e() from the compass version because e seems to be a escaping function for javascript based less variant but we dont need them on compass/sass/scss side so we can remove theme safetly here ?!

@chriseppstein
Copy link

Agree with @blackice2999, you shouldn't need to escape in sass.

@digerata
Copy link
Contributor Author

I sent a pull request that does just that.

@leonderijke
Copy link

Since it is fixed in c4155a3 this issue can be closed, I guess.

When will a new gem be pushed?

@carpeliam
Copy link

Seems like this has been addressed, and this should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants