Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compass mixins when possible #28

Open
ericdfields opened this issue Feb 10, 2012 · 5 comments
Open

Use compass mixins when possible #28

ericdfields opened this issue Feb 10, 2012 · 5 comments

Comments

@ericdfields
Copy link

Since the name of the project assumes a dependency on compass, why not cut down on some code by using pre-existing mixins for things like box-shadow instead of emulating twitter's less functions?

I did the same in another port, not realizing this one was already so mature ;-) https://github.com/hecbuma/compass-bootstrap

@vwall
Copy link
Owner

vwall commented Feb 10, 2012

That's how this project started out, I was just in a hurry to push out 2.0. I would like to make the parser do this. It's really no fun doing it by hand.

@aaronchi
Copy link

Yep. default compass box-shadow mixin is getting overwritten and causing problems.

@wyuenho
Copy link
Contributor

wyuenho commented Mar 10, 2012

background-size is getting overwritten too. It maybe wise to prefix all compass-twitter-bootstrap mixins mixin includes to avoid future name conflicts again.

@tijsverkoyen
Copy link
Contributor

see #87

@ldexterldesign
Copy link

Ditto, comment out the Compass Bootstrap box-shadow() @mixin and revert back to Compass' version, which works.

Hope to see this fixed in the next release.

Kind regards,

PS Love you work here on the port - keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants