We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, eos_constrain_step fallbacks to unconstrained condition.
CubicEoS.jl/src/vt_split/vt_split.jl
Lines 64 to 76 in bcb215f
I guess, it's better to let users define default constrain step function.
It may be defined as eos_constrain_step_factory(::Eos, ::Variables) -> eos_constrain_step(::Vars, x, d) or similar.
eos_constrain_step_factory(::Eos, ::Variables) -> eos_constrain_step(::Vars, x, d)
In CubicEoS interface, we define the factory producing unconstrain step, this is CubicEoS's default. But, user can define it's own default.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Currently, eos_constrain_step fallbacks to unconstrained condition.
CubicEoS.jl/src/vt_split/vt_split.jl
Lines 64 to 76 in bcb215f
I guess, it's better to let users define default constrain step function.
It may be defined as
eos_constrain_step_factory(::Eos, ::Variables) -> eos_constrain_step(::Vars, x, d)
or similar.In CubicEoS interface, we define the factory producing unconstrain step, this is CubicEoS's default. But, user can define it's own default.
The text was updated successfully, but these errors were encountered: