Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The package is not AD-friendly #10

Open
vvpisarev opened this issue Sep 16, 2021 · 0 comments
Open

The package is not AD-friendly #10

vvpisarev opened this issue Sep 16, 2021 · 0 comments

Comments

@vvpisarev
Copy link
Owner

vvpisarev commented Sep 16, 2021 •
edited
Loading

Types in some functions are too constrained to use with numeric types in AD packages.

For example, ForwardDiff.jacobian does not work with nmol -> log_c_activity(::BrusilovskyEoSMixture{Float64}, nmol, vol, RT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More generic buffer types to support autodiff vvpisarev/CubicEoS.jl
1 participant
@vvpisarev