Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make properties in T for IronSession<T> optional (union with undefined) #661

Open
jotatoledo opened this issue Dec 5, 2023 · 1 comment · May be fixed by #842
Open

Make properties in T for IronSession<T> optional (union with undefined) #661

jotatoledo opened this issue Dec 5, 2023 · 1 comment · May be fixed by #842
Labels
pr-welcome

Comments

@jotatoledo
Copy link

In case that there is no seal/cookie, the parsed data is an empty object.
For this reason, it would be more accurate to make the properties of the type parameter T optional.
@vvo
Copy link
Owner

vvo commented Jun 14, 2024

@jotatoledo Can you open a PR? As I am unsure what is it required to fix here.

@vvo vvo added the pr-welcome label Jun 14, 2024
@mattrossman mattrossman linked a pull request Sep 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr-welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make properties in T for IronSession<T> optional mattrossman/iron-session
2 participants
@vvo @jotatoledo