Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - firewall.createRules() does not work #449

Closed
apeters1827 opened this issue Mar 19, 2021 · 2 comments
Closed

[BUG] - firewall.createRules() does not work #449

apeters1827 opened this issue Mar 19, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@apeters1827
Copy link
Contributor

Describe the bug
When trying to execute a function, an empty object is immediately returned, but the rule is not created. With curl (with the same parameters) everything works correctly.

@apeters1827 apeters1827 added the bug Something isn't working label Mar 19, 2021
@spencerkordecki
Copy link
Collaborator

@gabos31 if the rule is already created, then the call will throw an error. I was able to successfully create firewall rule via the library when using a port where a rule didn't already exist.

That said, I can definitely see where our error handling can be improved and have opened #450 to deal with this.

@apeters1827
Copy link
Contributor Author

@spencerkordecki yes, the error was on my side, I was passing the subnet_size as a number (since it is returned as a number when asking for a list of rules), not as a string. It would be great to receive informative error messages in such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants