[BUG] - Makefile will not build due to reliance on bash in scripts/fmtcheck.sh

[shawnmchugh]

Describe the bug
The makefile to build the terraform-provider-vultr will not build due to scripts/fmtcheck.sh having an implicit reliance on bash being present on the system.

To Reproduce
Steps to reproduce the behavior:

1. cd $GOPATH/src/github.com/vultr/terraform-provider-vultr
2. gmake build

Expected behavior
Expected makefile and associated scripts to use POSIX compliant shell for portability to systems that use a different default shell, such as OpenBSD, MacOS, etc.

Screenshots/Output
env: bash: No such file or directory
gmake: *** [GNUmakefile:32: fmtcheck] Error 127

Desktop (please complete the following information where applicable:

• OS: OpenBSD 7.3
• Language Version: Go 1.20.1, latest terraform-provider-vultr release
• Shell: OpenBSD ksh

Additional context

Not sure if this is a bug or feature request, but seems more of a bug, since any other system not using bash as a default will have the same issue. I already have gmake on the system, I'd rather not have to install bash as well. I am able to work around the issue by using gofmt and go install manually or from another script/makefile, of course, but not ideal.

[optik-aper]

Thanks for the report. We should support POSIX compliance and will attempt to do so.