Skip to content

Commit 19933ff

Browse files
committed
fix(VAutocomplete/VCombobox): consistent open/close transition
1 parent ca85fc0 commit 19933ff

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/vuetify/src/components/VAutocomplete/VAutocomplete.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import './VAutocomplete.sass'
33

44
// Components
5+
import { VDialogTransition } from '@/components/transitions'
56
import { VAvatar } from '@/components/VAvatar'
67
import { VCheckboxBtn } from '@/components/VCheckbox'
78
import { VChip } from '@/components/VChip'
@@ -40,7 +41,7 @@ import {
4041
} from '@/util'
4142

4243
// Types
43-
import type { PropType } from 'vue'
44+
import type { Component, PropType } from 'vue'
4445
import type { VFieldSlots } from '@/components/VField/VField'
4546
import type { VInputSlots } from '@/components/VInput/VInput'
4647
import type { FilterMatch } from '@/composables/filter'
@@ -87,7 +88,7 @@ export const makeVAutocompleteProps = propsFactory({
8788
modelValue: null,
8889
role: 'combobox',
8990
}), ['validationValue', 'dirty', 'appendInnerIcon']),
90-
...makeTransitionProps({ transition: false }),
91+
...makeTransitionProps({ transition: { component: VDialogTransition as Component } }),
9192
}, 'VAutocomplete')
9293

9394
type ItemType<T> = T extends readonly (infer U)[] ? U : never

packages/vuetify/src/components/VCombobox/VCombobox.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import './VCombobox.sass'
33

44
// Components
5+
import { VDialogTransition } from '@/components/transitions'
56
import { VAvatar } from '@/components/VAvatar'
67
import { VCheckboxBtn } from '@/components/VCheckbox'
78
import { VChip } from '@/components/VChip'
@@ -41,7 +42,7 @@ import {
4142
} from '@/util'
4243

4344
// Types
44-
import type { PropType } from 'vue'
45+
import type { Component, PropType } from 'vue'
4546
import type { VFieldSlots } from '@/components/VField/VField'
4647
import type { VInputSlots } from '@/components/VInput/VInput'
4748
import type { FilterMatch } from '@/composables/filter'
@@ -91,7 +92,7 @@ export const makeVComboboxProps = propsFactory({
9192
modelValue: null,
9293
role: 'combobox',
9394
}), ['validationValue', 'dirty', 'appendInnerIcon']),
94-
...makeTransitionProps({ transition: false }),
95+
...makeTransitionProps({ transition: { component: VDialogTransition as Component } }),
9596
}, 'VCombobox')
9697

9798
type ItemType<T> = T extends readonly (infer U)[] ? U : never

0 commit comments

Comments
 (0)