-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to markdown config does not propagate. #664
Comments
It's reported by #664, but #664 cannot be fixed fully since watching webpack config changes shouldn't be handled in VuePresss VuePress can only ensure that when user changes the markdown config, the cache identifier will be updated, so user needn't to clean the ./node_modules/.cache muanully. See: webpack/webpack#3153, webpack/webpack-cli#15
It's reported by #664, but #664 cannot be fixed fully since watching webpack config changes shouldn't be handled in VuePresss VuePress can only ensure that when user changes the markdown config, the cache identifier will be updated, so user needn't to clean the ./node_modules/.cache manually. See: webpack/webpack#3153, webpack/webpack-cli#15
Thanks for the reporting, and it's not an OS-related issue. It's truly introduced by I have fixed this issue at 0ad1a45, but that's not a complete fix for this issue, we still cannot reach HMR, because we cannot watch webpack config changes for now. (See: webpack/webpack#3153, webpack/webpack-cli#15) VuePress can only ensure that when user changes the markdown config, the cache identifier will be updated, so user needn't to clean the |
@ulivz: Is your change meant to re-render the markdown when you alter When I update them the page refreshes, but the content doesn't change. I instead have to restart the dev server and alter some of the surrounding text to get the changes to propagate. |
edit: nevermind, I can't read (as usual). Yes, you have to restart the dev-server and update the md-file in question (That's what @ulivz HMR comment is about). Before 0.13.0 you had to manually remove your cache-folder to see any changes so tons of improvement but not perfect yet. I can understand that HMR might be unfeasible, but perhaps it could be possible to invalidate existing rendered markdown-cache after changes to the markdown-config? I mean who would want to keep their old output after making changes that (almost certainly) would change that output? (it would make my life a little little bit easier anyway!) Thanks for the hard work @ulivz! |
Oh right, the current behaviour is definitely an improvement from that, even if it is still a little frustrating! Thanks for the fix @ulivz! Is there another issue tracking this problem? I wasn't able to find one... 😅 |
I'm currently using |
Bug report
Any markdown-options in
config.js
seems to get cached the first time you usevuepress build
orvuepress dev
and and further changes make no difference. Not even removing markdown from the config has any effect.Version
0.12.0
Steps to reproduce
(In windows cmd):
What is expected?
Changes to
markdown: {...}
inconfig.js
should update immediately (HMR) usingvuepress dev
, or at the very least the next time your restartdev
or usebuild
. This is expected because that's how other changes inconfig.js
update. (For example:themeConfig:{search:false}
)What is actually happening?
After the first build/dev any further changes to the
markdown
object inconfig.js
has no effect..Other relevant information
I can force update by deleting the cache folder at (
%appdata%\nvm\v8.11.3\node_modules\vuepress\node_modules\.cache
)I would guess this problem is the reason to issues such as this: #526
And if this is a windows only issue, I'd like to point out something that may or may not be related:
If I run vuepress from
c:\projects\test\
instead ofC:\projects\test\
(notice upper case C) then I get the following warning:Things seems to run fine despite the warning, I'm just suggesting that if vuepress has a problem with paths in windows, maybe the same is true about vuepresses cache handling?
Windows 10
8.3.11
Version 67.0.3396.99 (Official Build) (64-bit)
vuepress is installed globally
[email protected]
The text was updated successfully, but these errors were encountered: