Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Mode Toggle with Light Icon to Indicate Light Mode Switch and Vice Versa #3227

Open
vikas-yadav2002 opened this issue Oct 3, 2024 · 0 comments

Comments

@vikas-yadav2002
Copy link

Feature request

What problem does this feature solve?

Currently, the dark mode toggle may cause confusion as users might expect the icon to represent the current mode instead of the mode they are switching to. By showing a light icon when in dark mode, it will clearly indicate that clicking the button will switch to light mode, improving the user experience and reducing ambiguity.

What does the proposed API look like?

A toggle button that shows a light icon (e.g., sun) when dark mode is active, indicating that clicking it will switch to light mode.

How should this be implemented in your opinion?

The button's icon should change dynamically based on the current mode:

  • In dark mode: show a light icon to suggest the user can switch to light mode.
  • In light mode: show a dark icon to suggest the user can switch to dark mode.

Are you willing to work on this yourself?

Yes, I am willing to work on this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@vikas-yadav2002 and others