Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importRecords Message #128

Closed
spgarbet opened this issue May 10, 2023 · 2 comments
Closed

importRecords Message #128

spgarbet opened this issue May 10, 2023 · 2 comments
Labels
enhancement

Comments

@spgarbet
Copy link
Member

This message " The following (if any) conditions were noted about the data." appears over and over even when everything is perfect. It would be better if this only appears upon an error. Automated reports tend to get cluttered and it provides no information.

Proposal: Remove this message altogether.
@nutterb
Copy link
Collaborator

nutterb commented May 10, 2023

Yes please!

This is one thing I had in mind with #113 . whatever clown came up with the idea to print messages out like that shouldn't be allowed to touch this project ever again......

@spgarbet
Copy link
Member Author

Agree in full. I tested commenting it out and the test cases are a lot cleaner.

spgarbet added a commit that referenced this issue May 10, 2023
@spgarbet
Removing extraneous import message #128
69677d0
spgarbet added a commit that referenced this issue May 10, 2023
@spgarbet
Merge pull request #129 from vubiostat/issue-128
410f9a4 
Removing extraneous import message #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spgarbet @nutterb