Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer versions of Unbound require the "include:" line in its own stanza #349

Open
nitrogen76 opened this issue Aug 13, 2024 · 1 comment

Comments

@nitrogen76
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet:7.13.1
  • Ruby:
  • Distribution: oracle linux 8
  • Module version: 7.0.0

How to reproduce (e.g Puppet code you use)

inside of a yaml:

unbound::custom_server_conf:
  - 'include: "/etc/unbound/conf.d/*.conf"'

What are you seeing

Having an "include:" line in places in the server: stanza with newer versions of unbound (started with unbound-1.16.2-5.el8_9.6 in ol8 appstream, but also happens with the latest 1.20 version i compiled) will error out upon configcheck.

What behaviour did you expect instead

It'd be nice to have a dedicated module command to set the include: directive outside of the server stanza, in its own stanza like the example config for unbound.conf does:

https://github.com/NLnetLabs/unbound/blob/master/doc/example.conf.in

# Use this anywhere in the file to include other text into this file.
#include: "otherfile.conf"

# Use this anywhere in the file to include other text, that explicitly starts a
# clause, into this file. Text after this directive needs to start a clause.
#include-toplevel: "otherfile.conf"

# The server clause sets the main parameters.
server:
	# whitespace is not necessary, but looks cleaner.

Output log

Any additional information you'd like to impart

@b4ldr
Copy link
Member

b4ldr commented Aug 29, 2024

this seems related to #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants