Skip to content

Commit 15432e1

Browse files
authored
Merge pull request #58 from rwaffen/update
Also push to dockerhub
2 parents a3b0a17 + 1a75cc0 commit 15432e1

File tree

4 files changed

+61
-24
lines changed

4 files changed

+61
-24
lines changed

.github/workflows/build_docker.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,29 @@ name: Build and publish a 🛢️ container
22

33
on:
44
push:
5-
paths-ignore:
6-
- '.github/**'
75
branches:
86
- 'master'
97
tags:
108
- '*'
119

10+
env:
11+
TAG: ${{ github.ref_name == 'master' && 'development' || github.ref_name }}
12+
1213
jobs:
1314
build-and-push-container:
1415
runs-on: ubuntu-latest
1516
permissions:
1617
contents: read
1718
packages: write
1819
steps:
19-
- uses: voxpupuli/gha-build-and-publish-a-container@v1
20+
- uses: voxpupuli/gha-build-and-publish-a-container@v2
2021
with:
21-
github_token: ${{ secrets.GITHUB_TOKEN }}
22+
registry_password: ${{ secrets.GITHUB_TOKEN }}
2223
build_arch: linux/amd64,linux/arm64
24+
docker_username: voxpupulibot
25+
docker_password: ${{ secrets.DOCKERHUB_BOT_PASSWORD}}
26+
tags: |
27+
ghcr.io/${{ github.repository }}:${{ env.TAG }}
28+
ghcr.io/${{ github.repository }}:latest
29+
docker.io/${{ github.repository }}:${{ env.TAG }}
30+
docker.io/${{ github.repository }}:latest

Gemfile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
source ENV['GEM_SOURCE'] || "https://rubygems.org"
1+
# frozen_string_literal: true
22

3-
gem 'serverspec', :require => false
4-
gem 'docker-api', :require => false
3+
source ENV['GEM_SOURCE'] || 'https://rubygems.org'
4+
5+
gem 'docker-api', require: false
6+
gem 'serverspec', require: false
57

68
group :release do
7-
gem 'github_changelog_generator', '>= 1.16.1', :require => false
9+
gem 'github_changelog_generator', '>= 1.16.1', require: false
810
end

README.md

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,32 @@
1-
Puppet Catalog Diff Viewer
2-
===========================
1+
# Puppet Catalog Diff Viewer
32

43
[![License](https://img.shields.io/github/license/voxpupuli/puppet-catalog-diff-viewer.svg)](https://github.com/voxpupuli/puppet-catalog-diff-viewer/blob/master/LICENSE)
54
[![CI](https://github.com/voxpupuli/puppet-catalog-diff-viewer/actions/workflows/ci.yaml/badge.svg)](https://github.com/voxpupuli/puppet-catalog-diff-viewer/actions/workflows/ci.yaml)
65
[![Donated by Camptocamp](https://img.shields.io/badge/donated%20by-camptocamp-fb7047.svg)](#transfer-notice)
76

8-
97
A viewer for json reports produced by [the puppet-catalog-diff tool](https://github.com/voxpupuli/puppet-catalog-diff)
108

11-
The interface can be tried online at http://voxpupuli.org/puppet-catalog-diff-viewer.
9+
The interface can be tried online at <http://voxpupuli.org/puppet-catalog-diff-viewer>.
1210

13-
Acking diffs
14-
------------
11+
## Acking diffs
1512

1613
This interface allows to ack differences in order to ease the report review. Differences are acked on all nodes that have the same resource with the same diff.
1714

1815
A global acking button is available for sections which allows to ack all diffs in the section at once.
1916

20-
Starring diffs
21-
--------------
17+
## Starring diffs
2218

2319
When using the global acking button, you might want to exclude some diffs from the global acking. Starring diffs does just that. Just as for acks, stars are cross-nodes.
2420

25-
Using with Docker
26-
-----------------
21+
## Using with Docker
2722

2823
```shell
2924
$ docker run -it --rm -p 8080:80 ghcr.io/voxpupuli/puppet-catalog-diff-viewer:development
3025
```
3126

3227
will let you access the catalog diff viewer at [http://localhost:8080](http://localhost:8080).
3328

34-
Server Side storage
35-
-------------------
29+
## Server Side storage
3630

3731
The will automatically populate the drop-down list of available reports, if they can be read from `reportlist.json`.
3832
This file contains a record of the json files in `data`.
@@ -64,8 +58,7 @@ $ docker run -ti \
6458
ghcr.io/voxpupuli/puppet-catalog-diff-viewer
6559
```
6660

67-
S3 storage
68-
----------
61+
## S3 storage
6962

7063
The viewer can automatically retrieve catalogs from an S3 bucket. In order to use this feature, create a `s3_credentials.js` file with the following variables:
7164

@@ -141,8 +134,13 @@ Make sure the access key belongs to a user that can perform actions `s3:GetObjec
141134
}
142135
```
143136

144-
Transfer Notice
145-
---------------
137+
## Contributing
138+
139+
### Build a release
140+
141+
see [RELEASE.md](RELEASE.md)
142+
143+
## Transfer Notice
146144

147145
This project was originally authored by [Camptocamp](http://www.camptocamp.com).
148146
The maintainer preferred that Vox Pupuli take ownership of the project for future improvement and maintenance.

RELEASE.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# How to release
2+
3+
## On a fork do
4+
5+
```shell
6+
git switch -c release-x.y.z
7+
```
8+
9+
Edit [Rakefile](Rakefile) and set future version.
10+
11+
```shell
12+
bundle config set --local path vendor/bundle
13+
bundle config set --local with 'release'
14+
bundle install
15+
16+
CHANGELOG_GITHUB_TOKEN="token_MC_token-face" bundle exec rake changelog
17+
git add -A
18+
git commit -m 'Release X.Y.Z'
19+
git push origin releae-x.y.z
20+
```
21+
22+
## as a maintainer on upstream do
23+
24+
```shell
25+
git switch master
26+
git pull
27+
git tag $version
28+
git push --tags
29+
```

0 commit comments

Comments
 (0)