Rework exception handling #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Apr 23, 2021
This commit gives the user a better output message: - it uses the exception message if available or fallback on the "Error during update" message - it prefixes the message by the current module name This commits introduces a ModuleSync::Error that will be used to raise exceptions, with a message outputed on stderr, but without a full backtrace, useless for user. It keeps the current behavior when error (ie. StandardError) comes from templates (ie. ERB) rendering as user may need to see why the rendering failed. Git::GitExecuteError backtraces are now hidden too: user needs to understand what happends, with the error message, but not where error occured.
neomilium
force-pushed
the
rework-exception-handling
branch
from
a31b0b8 to
8093878
Compare
ekohl
reviewed
Apr 23, 2021
ekohl
reviewed
Apr 23, 2021
|
@ekohl Big green button? |
ekohl
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit gives the user a better output message:
This commits introduces a ModuleSync::Error that will be used to raise
exceptions, with a message outputed on stderr, but without a full
backtrace, useless for user.
It keeps the current behavior when error (ie. StandardError) comes from
templates (ie. ERB) rendering as user may need to see why the rendering
failed.
Git::GitExecuteError backtraces are now hidden too: user needs
to understand what happends, with the error message, but not where error
occured.