Ruby 2.6 support #437
Closed
Ruby 2.6 support #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of ruby 2.6 the error raise here includes a string with the offending IP in it, which causes the matching to fail. We could just ditch string matching altogether except for 1.9.3 support, which raises a generic ArugmentError.
lukeasrodgers
commented
May 27, 2019
| @@ -10,6 +10,7 @@ def self.validate(current_schema, data, fragments, processor, validator, options | |||
|
|
|||
| begin | |||
| ip = IPAddr.new(data) | |||
| rescue IPAddr::InvalidAddressError | |||
There was a problem hiding this comment.
I considered adding a comment here, since it is confusing, but left explanation in the commit message instead. Happy to add an explicit comment if preferable.
These rubies do not have `IPAddr::InvalidAddressError` defined.
|
Hey people, could we get this merged and released? It's also breaking the tests on Ruby 2.7 |
|
Hi! |
|
Thank you for your contribution. This functionality has been added with PR #457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an
IPAddrvalidation error issue with ruby 2.6.Fixes #430